[STR-2295] FacesRequestProcessor call to lifecycle.render(context) needs to be wrapped in a try, finally

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.4
• Component/s: JSF Integration (Dormant)
• Environment: Operating System: All; Platform: PC
• Bugzilla Id: https://issues.apache.org/bugzilla/show_bug.cgi?id=32370
• Assignee: Unassigned
• Reporter: Chris Fraser
• Created: 24/Nov/04 10:35
• Updated: 16/Feb/11 19:52
• Resolved: 04/Jul/07 06:30

Description

In FacesRequestProcessor.doForward() (as well as FacesTilesRequestProcessor), if
the call to lifecycle.render(context) throws an exception, then the context is
never given a chance to be released, resulting in an invalid FacesContext being
pegged to the executing thread.

The following code:
======== SNIP ========
lifecycle.render(context);
if (created) {
if (log.isTraceEnabled())

{ log.trace(" Releasing context for '" + uri + "'"); }

context.release();
} else {
if (log.isTraceEnabled())

{ log.trace(" Rendering completed"); }

}
======== /SNIP ========

Should probably be changed to something like:
======== SNIP ========
try

{ lifecycle.render(context); }

finally {
if (created) {
if (log.isTraceEnabled())

{ log.trace(" Releasing context for '" + uri + "'"); }

context.release();
} else {
if (log.isTraceEnabled())

{ log.trace(" Rendering completed"); }

}
}
======== /SNIP ========