[STR-188] OptionsTags use toString instead of a Cast: (String)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0 Beta 2
• Fix Version/s: 1.0.0
• Component/s: Tag Libraries
• Environment: Operating System: All; Platform: PC
• Bugzilla Id: 1825
• Assignee: Craig R. McClanahan
• Reporter: Johan Compagner
• Created: 20/May/01 11:37
• Updated: 04/Jul/07 03:36
• Resolved: 04/Jul/07 03:36

Description

Hi,

I always change this:

String value = (String)valuesIterator.next();
String label = value;
if (labelsIterator.hasNext())
label = (String)labelsIterator.next();

to this:
String value = valuesIterator.next().toString();
String label = value;
if (labelsIterator.hasNext())
label = labelsIterator.next().toString();

In the current state i always must have Strings into the collections
But many times especially form values i have a Integer array
(if i could use int[] it was even better) as id's
So calling to string instead of the cast is a much better approace and
don't bound you to using strings.
Maybe there should be a extra null check then?

johan