[STR-1709] FormTag: Add check for nonexistent form field in focus javascript

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.3.10, 1.4.0
• Component/s: Tag Libraries
• Environment: Operating System: other; Platform: Other
• Bugzilla Id: 22700
• Assignee: Unassigned
• Reporter: Jonathan Gritzman
• Created: 25/Aug/03 22:56
• Updated: 01/Jul/07 17:01
• Resolved: 27/Jun/07 02:24

Description

After processing the <html:form> tag, some javascript is displayed to force the
focus to one of the components in the form. However, it is possible that the
form field may not exist or may become a label if a user doesn't have modify
access to the field. In this case a javacript error of 'Object Not Found' is
displayed in a dialog box when the page is loaded.

The existing javascript focuses into the form field provided the field isn't hidden.

However, an additional check should be performed to ensure that the form field
exists. Only then (in addition to the field not being hidden) should the
javascript move the focus to the field.

Resolution
----------
In the FormTag's doEndTag() method a call is made to renderFocusJavascript().

The renderFocusJavascript() method does the following:
results.append(" if (focusControl.type != \"hidden\") {");

Change this to:
// Was previously setting the focus to the first text component
// if it wasn't a hidden field.
// Add an extra check to verify that the field exists.
results.append(" if (! focusControl.type === undefined && ");
results.append(" focusControl.type != \"hidden\") {");