[STR-1495] Bug in FieldChecks.validateRequiredIf(...)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Nightly Build
• Fix Version/s: 1.1 Family
• Component/s: Core
• Environment: Operating System: All; Platform: All
• Bugzilla Id: 20455
• Assignee: Unassigned
• Reporter: Bradley M. Handy
• Created: 03/Jun/03 23:04
• Updated: 16/Feb/11 19:44
• Resolved: 04/Jul/07 05:29

Description

I have a validation that should be failing (under certain conditions),
but is not. I've double checked and triple checked to make sure the
setup is correct, and it's still not working correctly.

So, I took a look at the code for "validateRequiredIf" in
the "org.apache.struts.validator.FieldChecks" class. At the end of
the method I found this segment of code:

if (required) {
if ((value != null) && (value.length() > 0))

{ return true; }

else

{ errors.add(field.getKey(), Resources.getActionError(request, va, field)); return false; }

}

Am I correct in assuming that the following condition "((value != null) &&
(value.length() > 0))" should be "(!GenericValidator.isBlankOrNull(value))".
The reason my check is failing is due to the fact the value I'm checking is
all white space (at certain times), and is selected from a select box.