[STORM-538] Guava com.google.thirdparty.publicsuffix is not shaded

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.3
• Fix Version/s: 0.9.3, 0.9.3-rc2
• Component/s: storm-core
• Labels: shade
• Assignee: Unassigned
• Reporter: Damien Raude-Morvan
• Created: 20/Oct/14 23:00
• Updated: 05/Oct/15 01:39
• Resolved: 27/Oct/14 20:44

Description

Hi!

I've just tried last 0.9.3-rc1 release which is available on http://storm.apache.org and I got an issue with seems to be linked to STORM-447.

Here is the following stacktrace (stripping our package from trace) :

java.lang.NoSuchFieldError: EXACT
at com.google.common.net.InternetDomainName.findPublicSuffix(InternetDomainName.java:173)
at com.google.common.net.InternetDomainName.<init>(InternetDomainName.java:158)
at com.google.common.net.InternetDomainName.from(InternetDomainName.java:213) 
[...]

EXACT field is expected to be present in com.google.thirdparty.publicsuffix.PublicSuffixPatterns

Having a quick look at storm-core-0.9.3-rc1.jar contents :

• com.google.common is relocated to org.apache.storm.guava
• com.google.thirdparty.publicsuffix is not relocated so it might conflict with user code (that's my case)

Regards,