Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3683

Check for consistency in JVM options for worker launch

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: In Progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: storm-client
    • Labels:
      None

      Description

      If GC options are specified in topology.worker.childopts, they could conflict with the cluster settings and cause problems launching the JVM. This leads to storm alerts due to failures launching containers.

      We could catch these on submission and prevent the topology from launching with an error message.

      Kishor Patil's further comments:

      Submit time validation of JVM Options includes..

      Running `java -showversion` kind of command while topology is being submitted using JVM_OPTIONS derived using

      1. topology.worker.childopts
      2. topology.worker.gc.childopts
      3. topology.worker.logwriter.childopts
      4. worker.childopts
      5. worker.gc.childopts
      6. worker.profiler.childopts

      And removing replacement strings such as "%ID%", "%WORKER-ID%", "%TOPOLOGY-ID%", "%WORKER-PORT", "%OFF-HEAP-MEM%", "%LIMIT-MEM%" with dummy values. To perform these replacements with dummy values, I would use externalize and use the logic from BasicContainer#substituteChildOptsInternal method.

        Attachments

          Activity

            People

            • Assignee:
              bipinprasad Bipin Prasad
              Reporter:
              bipinprasad Bipin Prasad

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h 10m
                3h 10m

                  Issue deployment