[STORM-328] Config.java and Utils.get{Int,Long} are not in sync for floating point

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.2-incubating, 0.9.1-incubating, 0.9.0.1
• Fix Version/s: 0.9.3
• Component/s: storm-core
• Labels: newbie
• Assignee: Jungtaek Lim
• Reporter: Robert Joseph Evans
• Created: 20/May/14 14:14
• Updated: 05/Oct/15 02:12
• Resolved: 15/Jul/14 14:22

Description

For most numeric configuration values Config.java has a type of Number listed, but the values are parsed using Utils.getInt or Utils.getLong, which means if someone gave a floating point number it would pass the ConfigValidation, but would blow up when it is used. This is most critical for values that Nimbus reads, but would be good to have them consistent everywhere.

We should also check that getInt works properly for numbers that are larger then would fit in an integer.

Either we need to update Utils to be more lenient when looking at doubles, or we need to make Config more strict, which may be difficult with the YAML and JSON parsing that happens, where ints are often converted into longs.