[STORM-3098] Fix bug in filterChangingBlobsFor() in Slot.java

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: storm-server
• Labels: pull-request-available
• Assignee: Zhengdai Hu
• Reporter: Zhengdai Hu
• Due: 07/Jun/18
• Created: 07/Jun/18 14:02
• Updated: 08/Jun/18 14:02
• Resolved: 08/Jun/18 14:02

Description

The following method is not implemented correctly

 private static DynamicState filterChangingBlobsFor(DynamicState dynamicState, final LocalAssignment assignment) {
        if (!dynamicState.changingBlobs.isEmpty()) {
            return dynamicState;
        }

        HashSet<BlobChanging> savedBlobs = new HashSet<>(dynamicState.changingBlobs.size());
        for (BlobChanging rc : dynamicState.changingBlobs) {
            if (forSameTopology(assignment, rc.assignment)) {
                savedBlobs.add(rc);
            } else {
                rc.latch.countDown();
            }
        }
        return dynamicState.withChangingBlobs(savedBlobs);
    }

It doesn't modify dynamicState in anyway.
The solution is to remove the negation in the first if statement.

Issue Links

• links to: GitHub Pull Request #2708