Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-3092

Metrics Reporter and Shutdown Hook on Supervisor not properly set up at launchDaemon

    Details

      Description

      The bug was introduced in commit 0dac58b0aa82133df242b3b2ebeb65bfea7d63cc, when launchSupervisorThriftServer method is invoked in the launchDaemon method in Supervisor class. launchSupervisorThriftServer() invokes a blocking call to thrift server under the hood, hence preventing Utils.addShutdownHookWithForceKillIn1Sec and StormMetricsRegistry.startMetricsReporters from correctly called. 

       

      The bug can be solved by moving launchSupervisorThriftServer to the end of the code block.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                zhengdai Zhengdai Hu
                Reporter:
                zhengdai Zhengdai Hu
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 24h
                  24h
                  Remaining:
                  Time Spent - 0.5h Remaining Estimate - 23.5h
                  23.5h
                  Logged:
                  Time Spent - 0.5h Remaining Estimate - 23.5h
                  0.5h