[STORM-3092] Metrics Reporter and Shutdown Hook on Supervisor not properly set up at launchDaemon

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: storm-server
• Labels: pull-request-available
• Assignee: Zhengdai Hu
• Reporter: Zhengdai Hu
• Created: 01/Jun/18 18:33
• Updated: 05/Jun/18 17:03
• Resolved: 05/Jun/18 17:03

Description

The bug was introduced in commit 0dac58b0aa82133df242b3b2ebeb65bfea7d63cc, when launchSupervisorThriftServer method is invoked in the launchDaemon method in Supervisor class. launchSupervisorThriftServer() invokes a blocking call to thrift server under the hood, hence preventing Utils.addShutdownHookWithForceKillIn1Sec and StormMetricsRegistry.startMetricsReporters from correctly called. 

 

The bug can be solved by moving launchSupervisorThriftServer to the end of the code block.

Issue Links

• links to: GitHub Pull Request #2702