[STORM-2950] ArrayIndexOutOfBoundsException in FieldsGrouper.chooseTasks function

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Labels: pull-request-available
• Assignee: Ethan Li
• Reporter: Ethan Li
• Created: 14/Feb/18 21:01
• Updated: 18/Feb/18 00:06
• Resolved: 18/Feb/18 00:06

Description

TupleUtils.chooseTaskIndex:

public static <T> int chooseTaskIndex(List<T> keys, int numTasks) {
    return Math.abs(listHashCode(keys)) % numTasks;
}

 
listHashCode(keys) might return Integer.MIN_VALUE (-2147483648). Math.abs(-2147483648) equals to -2147483648.

In this case, chooseTaskIndex might return negative numbers and it will cause ArrayIndexOutOfBoundsException in FieldsGrouper.chooseTasks

 @Override
        public List<Integer> chooseTasks(int taskId, List<Object> values) {
            int targetTaskIndex = TupleUtils.chooseTaskIndex(outFields.select(groupFields, values), numTasks);
            return targetTasks.get(targetTaskIndex);
        }

 

Issue Links

• links to: GitHub Pull Request #2558