[STORM-2874] Minor style improvements to backpressure code

• Type: Task
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.0
• Fix Version/s: 1.2.0, 1.1.2, 1.0.6
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Stig Rohde Døssing
• Reporter: Stig Rohde Døssing
• Created: 29/Dec/17 21:21
• Updated: 03/Jan/18 16:02
• Resolved: 03/Jan/18 16:02

Description

The WorkerBackpressureThreadTest uses looped sleep-and-check on an AtomicLong to verify that the callback is called after notifying the trigger. We should use a countdown latch for this instead.

The WorkerBackpressureThreadTest extends TestCase, which is a bad idea because it makes the JUnit 4 annotations non-functional.

Issue Links

• links to: GitHub Pull Request #2488
• links to: GitHub Pull Request #2489