[STORM-2833] Cached Netty Connections can have different keys for the same thing.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0, 2.0.0
• Fix Version/s: 2.0.0, 1.2.0, 1.1.2
• Component/s: storm-client
• Labels: pull-request-available
• Assignee: Robert Joseph Evans
• Reporter: Robert Joseph Evans
• Created: 27/Nov/17 16:50
• Updated: 28/Nov/17 22:57
• Resolved: 28/Nov/17 22:57

Description

It turns out that if you set storm.local.hostname on your supervisors that the netty caching code might not work. The issue is that when we go to add a netty connection to the cache we use the host name provided by the scheduling. Which ultimately comes from the storm.local.hostname setting on each of the nodes. But when we go to remove it from the cache, we use the resolved INetSocket address for the destination. If the two do not match exactly then we can close a connection, but not have it removed from the cache, so when we go to try and use it again, the connection is closed.

Issue Links

• links to: GitHub Pull Request #2435
• links to: GitHub Pull Request #2436