Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2756

STORM-2548 on 1.x-branch broke setting key/value deserializers with the now deprecated setKey/setValue methods

    Details

      Description

      When STORM-2548 was backported, the setKey/setValue methods on KafkaSpoutConfig.Builder were deprecated, and users were directed to use setProp along with the relevant ConsumerConfig constants for setting deserializers instead.

      As part of this change, the KafkaConsumerFactoryDefault switched from using the KafkaConsumer(props, keyDes, valDes) constructor to using the KafkaConsumer(props) constructor. Unfortunately I forgot to update the KafkaSpoutConfig.Builder constructor properly, so if the user configures the deserializer via either the Builder constructor parameters or setKey/setValue, the setting is not put in the kafkaProps map and the deserializer is not used.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Srdo Stig Rohde Døssing
                Reporter:
                Srdo Stig Rohde Døssing
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 20m
                  20m