Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2720

Add timestamp based FirstPollOffsetStrategy in KafkaTridentSpoutOpaque

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      Offsets for a given partition at a particular timestamp can now be found using offsetsForTimes API. https://kafka.apache.org/0110/javadoc/org/apache/kafka/clients/consumer/KafkaConsumer.html#offsetsForTimes(java.util.Map).

      One way to make use of this api would be to :
      Add a new option for FirstPollOffsetStrategy called TIMESTAMP
      Add a new startTimeStamp option to KafkaSpoutConfig, which would be used only when FirstPollOffsetStrategy is set to TIMESTAMP.

      Later in the KafkaTridentSpoutEmitter, when we do the first seek, we can do something like :

                  if(firstPollOffsetStrategy.equals(TIMESTAMP)) {
                      try {
                          startTimeStampOffset =
                              kafkaConsumer.offsetsForTimes(Collections.singletonMap(tp, startTimeStamp)).get(tp).offset();
                      } catch (IllegalArgumentException e) {
                          LOG.error("Illegal timestamp {} provided for tp {} ",startTimeStamp,tp.toString());
                      } catch (UnsupportedVersionException e) {
                          LOG.error("Kafka Server do not support offsetsForTimes(), probably < 0.10.1",e);
                      }
      
                      if(startTimeStampOffset!=null) {
                          LOG.info("Kafka consumer offset reset for TopicPartition {}, TimeStamp {}, Offset {}",tp,startTimeStamp,startTimeStampOffset);
                          kafkaConsumer.seek(tp, startTimeStampOffset);
                      } else {
                          LOG.info("Kafka consumer offset reset by timestamp failed for TopicPartition {}, TimeStamp {}, Offset {}. Restart with a different Strategy ",tp,startTimeStamp,startTimeStampOffset);
                      }
                  }
      

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            janithkv Janith Kaiprath Valiyalappil
            janithkv Janith Kaiprath Valiyalappil
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 10h
                10h

                Slack

                  Issue deployment