Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2629

Can't build site on Windows due to Nokogiri failing to install

    Details

    • Type: Bug
    • Status: In Progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: asf-site

      Description

      I'm using Windows 10's bash support, and I'm having some trouble building the site since Nokogiri won't install.

      Running 'configure' for libxml2 2.9.2... ERROR, review
      '/tmp/bundler20170714-31-159r6j1nokogiri-1.6.7.2/gems/nokogiri-1.6.7.2/ext/nokogiri/tmp/x86_64-pc-linux-gnu/ports/libxml2/2.9.2/configure.log'
      to see what happened. Last lines are:
      ========================================================================
      checking build system type... ./config.guess: line 4: $'\r': command not found
      ./config.guess: line 6: $'\r': command not found
      ./config.guess: line 33: $'\r': command not found
      

      Upgrading Nokogiri fixes this issue, so I'd like to upgrade the gemfile to the latest version of github-pages, i.e. run "bundler update". As far as I can tell, we only need to make a small number of changes to get it working.

      • It seems like the meaning of the page variable in a layout has changed in Jekyll. _layouts/about.html should use layout to refer to it's own variables instead of page (which would belong to the concrete page being rendered). The other layouts don't refer to their own front matter, so there shouldn't be any issue there
      • Jekyll has made redcarpet an optional dependency, so the gemfile should list that dependency explicitly
      1. STORM-2629.patch
        8 kB
        Stig Rohde Døssing

        Issue Links

          Activity

          Hide
          Srdo Stig Rohde Døssing added a comment -

          Attached proposed fix. I've clicked around a bunch on the Jekyll local server, and haven't noticed anything break. I'm not too familiar with Ruby and Google wasn't helpful, so I've just added an explicit redcarpet dependeny to the gemfile. If there's a better way to refer to https://github.com/jekyll/jekyll/blob/c7d98cae2652b2df7ebd3c60b4f8c87950760e47/Gemfile#L82 I'd like to change it.

          Show
          Srdo Stig Rohde Døssing added a comment - Attached proposed fix. I've clicked around a bunch on the Jekyll local server, and haven't noticed anything break. I'm not too familiar with Ruby and Google wasn't helpful, so I've just added an explicit redcarpet dependeny to the gemfile. If there's a better way to refer to https://github.com/jekyll/jekyll/blob/c7d98cae2652b2df7ebd3c60b4f8c87950760e47/Gemfile#L82 I'd like to change it.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user srdo opened a pull request:

          https://github.com/apache/storm-site/pull/1

          STORM-2629: Upgrade to latest github-pages to allow Windows build

          See https://issues.apache.org/jira/browse/STORM-2629

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/srdo/storm-site STORM-2629

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/storm-site/pull/1.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #1


          commit 5601e679786871cff4affd6a98e07f74c7b0a6cd
          Author: Stig Rohde Døssing <stigdoessing@gmail.com>
          Date: 2017-09-09T18:34:19Z

          STORM-2629: Upgrade to latest github-pages to allow Windows build


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user srdo opened a pull request: https://github.com/apache/storm-site/pull/1 STORM-2629 : Upgrade to latest github-pages to allow Windows build See https://issues.apache.org/jira/browse/STORM-2629 You can merge this pull request into a Git repository by running: $ git pull https://github.com/srdo/storm-site STORM-2629 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/storm-site/pull/1.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1 commit 5601e679786871cff4affd6a98e07f74c7b0a6cd Author: Stig Rohde Døssing <stigdoessing@gmail.com> Date: 2017-09-09T18:34:19Z STORM-2629 : Upgrade to latest github-pages to allow Windows build
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user HeartSaVioR commented on the issue:

          https://github.com/apache/storm-site/pull/1

          Which pair(s) of OS and Ruby version are you trying out?
          I'm trying out the change but I'm experiencing crash on redcarpet. (redcarpet.rb has `require 'redcarpet.so'` but there's no file) macOS Sierra (10.12.6) and Ruby 2.4.1. Odd thing is that standalone command 'redcarpet' works.

          Show
          githubbot ASF GitHub Bot added a comment - Github user HeartSaVioR commented on the issue: https://github.com/apache/storm-site/pull/1 Which pair(s) of OS and Ruby version are you trying out? I'm trying out the change but I'm experiencing crash on redcarpet. (redcarpet.rb has `require 'redcarpet.so'` but there's no file) macOS Sierra (10.12.6) and Ruby 2.4.1. Odd thing is that standalone command 'redcarpet' works.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user srdo commented on the issue:

          https://github.com/apache/storm-site/pull/1

          @HeartSaVioR I've tried it out on Windows 10 and ruby 2.3.4p301. I just went and tested it on a fresh install of Ubuntu 17.04 and ruby 2.4.1p111.

          Did you run `bundler install` after switching to this branch?

          I'm wondering if the README is a little misleading, it's my understanding that people should use Bundler to update dependencies and run Jekyll, but the README doesn't mention it.

          Here's the commands I ran to start the local server:
          `bundler install`
          `bundler exec jekyll serve -w`

          Show
          githubbot ASF GitHub Bot added a comment - Github user srdo commented on the issue: https://github.com/apache/storm-site/pull/1 @HeartSaVioR I've tried it out on Windows 10 and ruby 2.3.4p301. I just went and tested it on a fresh install of Ubuntu 17.04 and ruby 2.4.1p111. Did you run `bundler install` after switching to this branch? I'm wondering if the README is a little misleading, it's my understanding that people should use Bundler to update dependencies and run Jekyll, but the README doesn't mention it. Here's the commands I ran to start the local server: `bundler install` `bundler exec jekyll serve -w`

            People

            • Assignee:
              Srdo Stig Rohde Døssing
              Reporter:
              Srdo Stig Rohde Døssing
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development