[STORM-260] Race condition in backtype.storm.utils.Time

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.2-incubating
• Fix Version/s: 0.9.2-incubating
• Component/s: storm-core
• Labels: patch test
• Assignee: Adrian Petrescu
• Reporter: Adrian Petrescu
• Created: 21/Mar/14 20:21
• Updated: 09/Oct/15 00:59
• Resolved: 18/Jun/14 17:43

Description

Some of my test runs were occasionally failing with a NullPointerException on backtype.storm.utils.Time.java:64.

After a bit of investigation, it seems there's a race condition here; if we disable simulating mode while a thread is currently sleeping, then when it wakes up it won't re-check if it's still in "simulating" mode, it'll try to remove the sleep time, and get the NPE.

The attached patch is a fairly straightforward fix.