Uploaded image for project: 'Apache Storm'
  1. Apache Storm
  2. STORM-2517

storm-hdfs writers can't be subclassed

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 2.0.0, 1.2.0
    • Component/s: storm-hdfs
    • Labels:
      None

      Description

      HdfsBolt.makeNewWriter() returns an AbstractHDFSWriter instead of an interface. AbstractHDFSWriter is public but its constructor is package-private so it can't actually be subclassed unless your class is in the org.apache.storm.hdfs.common package. I subclassed HDFSWriter but it required some workarounds.

      Also AbstractHDFSWriter.offset is package-private and write() is final, so there is no way for a subclass to control or update the offset after doWrite()

        Attachments

          Activity

            People

            • Assignee:
              Angus-slalom Angus Helm
              Reporter:
              Angus-slalom Angus Helm
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 3h
                3h