[STORM-2517] storm-hdfs writers can't be subclassed

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 2.0.0, 1.2.0
• Component/s: storm-hdfs
• Assignee: Angus Helm
• Reporter: Angus Helm
• Created: 16/May/17 21:40
• Updated: 28/Aug/17 22:13
• Resolved: 28/Aug/17 22:13

Description

HdfsBolt.makeNewWriter() returns an AbstractHDFSWriter instead of an interface. AbstractHDFSWriter is public but its constructor is package-private so it can't actually be subclassed unless your class is in the org.apache.storm.hdfs.common package. I subclassed HDFSWriter but it required some workarounds.

Also AbstractHDFSWriter.offset is package-private and write() is final, so there is no way for a subclass to control or update the offset after doWrite()

Issue Links

• links to: GitHub Pull Request #2138
• links to: GitHub Pull Request #2157
• links to: GitHub Pull Request #2294