[STORM-2483] wrong parameters order

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0, 1.0.3, 1.2.3, 2.1.0
• Fix Version/s: 1.2.4, 2.2.0, 2.1.1
• Component/s: storm-core
• Labels: pull-request-available
• Environment: storm-core:1.0.3
• Assignee: Nathan Day
• Reporter: Jacob Liu
• Created: 18/Apr/17 09:48
• Updated: 01/Jul/20 14:07
• Resolved: 19/Mar/20 14:07

Description

org.apache.storm.utils.Utils#getGlobalStreamId has wrong parameters order:

public static GlobalStreamId getGlobalStreamId(String streamId, String componentId) {
if (componentId == null)

{ return new GlobalStreamId(streamId, DEFAULT_STREAM_ID); }

return new GlobalStreamId(streamId, componentId);
}

but GlobalStreamId constructor is: public GlobalStreamId(
String componentId,
String streamId)

so i think the nice code is:
public static GlobalStreamId getGlobalStreamId(String streamId, String componentId) {
if (streamId == null)

{ return new GlobalStreamId(componentId, DEFAULT_STREAM_ID); }

return new GlobalStreamId(componentId, streamId);
}

Issue Links

• links to: GitHub Pull Request #3229
• links to: GitHub Pull Request #3230