[STORM-183] Supervisor/worker shutdown hook should be called in distributed mode.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.3
• Component/s: storm-core
• Assignee: Parth Brahmbhatt
• Reporter: caofangkun
• Created: 23/Dec/13 01:40
• Updated: 09/Oct/15 01:01
• Resolved: 25/Jun/14 14:04

Description

if the process is killed forcefully from the OS or if it's crashing due to resource issues (e.g., out of memory), shutdown hooks won't be invoked.
-TERM (15)
The process is requested to stop running; it should try to exit cleanly
-KILL (9)
The process will be killed by the kernel; this signal cannot be ignored.
So should we better use 'kill -15' ?
See:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/util.clj#L392

https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L175

will never be called for supervisor:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L396

will never be called for worker:
https://github.com/apache/incubator-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/worker.clj#L421

We'd better add something like :
(.addShutdownHook (Runtime/getRuntime) (Thread. (fn [] (.shutdown mk-sv)))))) ?

Issue Links

• is related to: STORM-126 Add Lifecycle support API for worker nodes