[STORM-1779] Incorrect bfs-ordering in DefaultResourceAwareStrategy

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.0.0
• Component/s: storm-core
• Labels: bug scheduler
• Flags: Important
• Assignee: Unassigned
• Reporter: Pavel Smirnov
• Created: 11/May/16 16:46
• Updated: 24/Aug/17 05:26
• Resolved: 24/Aug/17 05:26

Description

I have designed a simple diamond topology: spout, N parallel processingBolts, joinBolt.
https://github.com/smirnp/storm-benchmark/blob/1.0.0/src/storm/benchmark/DiamondTopology.java

For 6-components topopoly the breadth-first search (bfs method in DefaultResourceAwareStrategy.java:323) returns 13 components, which is obviously incorrect for further scheduling (it fails on memory limits trying to schedule already scheduled tasks in priorityToExecutorMap).

I have reimplemented bfs with the comparison with the original-one (https://github.com/smirnp/storm-benchmark/blob/1.0.0/bfs.txt)
Please check it and fix the bug in next releases.

P.S. storm.yaml user for scheduling is here:
https://github.com/smirnp/storm-benchmark/blob/1.0.0/storm.yaml

Best regards,
Thanks

Issue Links

• is duplicated by: STORM-1681 Bug in scheduling cyclic topologies when scheduling with RAS