Uploaded image for project: 'C++ Standard Library'
  1. C++ Standard Library
  2. STDCXX-913

inline virtual dtors causing code bloat in exception.cpp

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 4.2.1
    • 4.2.2
    • 27. Input/Output
    • None
    • gcc 4.3.0

    • Inefficiency

    Description

      Compiling exception.cpp with gcc 4.3 causes the warnings below. We should outline the virtual dtors to reduce the code bloat.

      gcc -c -I/home/sebor/stdcxx-4.2.1/include/ansi   -pthread -I/home/sebor/stdcxx-4.2.1/include -I/build/sebor/stdcxx-4.2.1-gcc-4.3.0-12D/include  -pedantic -nostdinc++ -O2   -W -Wall -Wcast-qual -Winline -Wshadow -Wwrite-strings -Wno-long-long -Wcast-align -g -pg -fPIC  /home/sebor/stdcxx-4.2.1/src/exception.cpp
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h: In function 'void __rw::__rw_throw_exception(int, char*)':
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:63: warning: inlining failed in call to 'virtual __rw::__rw_failbit_set::~__rw_failbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:715: warning: called from here
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:63: warning: inlining failed in call to 'virtual __rw::__rw_failbit_set::~__rw_failbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:715: warning: called from here
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:59: warning: inlining failed in call to 'virtual __rw::__rw_badbit_set::~__rw_badbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:719: warning: called from here
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:59: warning: inlining failed in call to 'virtual __rw::__rw_badbit_set::~__rw_badbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:719: warning: called from here
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:61: warning: inlining failed in call to 'virtual __rw::__rw_eofbit_set::~__rw_eofbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:723: warning: called from here
      /home/sebor/stdcxx-4.2.1/include/rw/_iosfailure.h:61: warning: inlining failed in call to 'virtual __rw::__rw_eofbit_set::~__rw_eofbit_set() throw ()': call is unlikely and code size would grow
      /home/sebor/stdcxx-4.2.1/src/exception.cpp:723: warning: called from here
      

      Attachments

        Activity

          People

            sebor Martin Sebor
            sebor Martin Sebor
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 1h Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 2h
                2h