[STDCXX-548] add an internal header for __rw::__rw_get_stdio_fmat()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.1.2, 4.1.3, 4.1.4
• Fix Version/s: 4.2.1
• Component/s: Build and Installation

Environment

All.

• Patch Info: Patch Available
• Severity: Linker Error
• Assignee: Farid Zaripov
• Reporter: Martin Sebor
• Created: 12/Sep/07 00:58
• Updated: 08/Feb/08 15:15
• Resolved: 08/Feb/08 15:15

Description

The _rw::_rw_get_stdio_fmat() function (and perhaps some others) defined in src/punct.cpp and declared as well as used in both num_get.cpp and num_put.cpp. Changing the function signature involves changing three places instead of two, which is error-prone. See http://svn.apache.org/viewvc?rev=574738&view=rev and http://svn.apache.org/viewvc?rev=574422&view=rev for an example where this caused breakage.

The function (and any other such examples) should be declared in a header to prevent such incidents.