[STDCXX-331] std::list::insert() violates strong exception safety requirements

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.3
• Fix Version/s: 4.2.0
• Component/s: 23. Containers

Environment

All

• Assignee: Farid Zaripov
• Reporter: Farid Zaripov
• Created: 01/Feb/07 10:29
• Updated: 06/Jun/07 09:53
• Resolved: 06/Jun/07 09:53

Description

The list::insert() method do not satisfy strong exception safety requirements (23.2.3.3 Remark 1).

Details are here:
http://mail-archives.apache.org/mod_mbox/incubator-stdcxx-dev/200701.mbox/[e-mail]%3e

test.cpp:
------------------------------
#include <list>
#include <cassert>

static int throw_inx = -1;

class ListItem
{
public:
static int count_;

void test ()

{ if (throw_inx == count_) throw count_; ++count_; }

ListItem ()

{ test (); }

ListItem (const ListItem&) { test (); }

~ListItem ()

{ --count_; }

};

int ListItem::count_ = 0;

int main (int argc, char* argv[])
{
typedef std::list<ListItem> List;
ListItem items [20];
List lst (1);

bool thrown = false;
throw_inx = 10;

List::iterator it = lst.begin ();
ListItem & ref = *it;

try

{ ListItem::count_ = 0; lst.insert (it, 20, items [0]); }

catch (...)

{ thrown = true; }

assert (thrown);
assert (it == lst.begin ());
assert (&ref == &*lst.begin ());
assert (1 == lst.size ());
assert (0 == ListItem::count_);

try { ListItem::count_ = 0; lst.insert (it, items, items + 20); } catch (...) { thrown = true; }

assert (thrown);
assert (it == lst.begin ());
assert (&ref == &*lst.begin ());
assert (1 == lst.size ());
assert (0 == ListItem::count_);

return 0;
}

The test output:
------------------------------
test: /usr/src/tests/test.cpp:48: int main(int, char**): Assertion `it == lst.begin ()' failed.
Aborted.