[STDCXX-268] std::list constructors do not call destructors for created objects if exception was thrown

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.3
• Fix Version/s: 4.2.0
• Component/s: 23. Containers

Environment

All

• Assignee: Farid Zaripov
• Reporter: Farid Zaripov
• Created: 08/Aug/06 08:30
• Updated: 06/Jun/07 10:04
• Resolved: 19/Feb/07 14:21

Description

std::list constructors do not satisfy basic exception safety requirement (no memory leaks) since they do not call destructors for created objects if exception was thrown.

See details here:
http://mail-archives.apache.org/mod_mbox/incubator-stdcxx-dev/200608.mbox/[e-mail]%3e

test.cpp:
-----------------------
#include <list>
#include <cassert>

static int throw_inx = -1;

class ListItem
{
public:
static int count_;

void test ()

{ if (throw_inx == count_) throw count_; ++count_; }

ListItem ()

{ test (); }

ListItem (const ListItem&) { test (); }

~ListItem ()

{ --count_; }

};

int ListItem::count_ = 0;

int main(int argc, char* argv[])
{
typedef std::list<ListItem> List;
ListItem items [20];
List lst (20);

bool thrown = false;
throw_inx = 10;

try

{ ListItem::count_ = 0; List test (20); }

catch (...)

{ thrown = true; }

assert (thrown);
assert (0 == ListItem::count_);

try { thrown = false; ListItem::count_ = 0; List test (20, items [0]); } catch (...) { thrown = true; }

assert (thrown);
assert (0 == ListItem::count_);

try

{ thrown = false; ListItem::count_ = 0; List test (items, items + 20); }

catch (...)

{ thrown = true; }

assert (thrown);
assert (0 == ListItem::count_);

try { thrown = false; ListItem::count_ = 0; List test (lst.begin (), lst.end ()); } catch (...) { thrown = true; }

assert (thrown);
assert (0 == ListItem::count_);

try

{ thrown = false; ListItem::count_ = 0; List test (lst); }

catch (...)

{ thrown = true; }

assert (thrown);
assert (0 == ListItem::count_);

return 0;
}

the test output:
---------------------
test: /usr/src/tests/test.cpp:45: int main(int, char**): Assertion `0 == ListItem::count_' failed.
Aborted.