[STANBOL-928] Null list on RuleStore RecipeImpl

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.12.0
• Component/s: Rules
• Assignee: Reto Gmür
• Reporter: Minto van der Sluis
• Created: 13/Feb/13 12:48
• Updated: 17/Jul/13 15:08
• Resolved: 20/Feb/13 17:27

Description

Hi folks,

Is there a specific reason why Recipe.getRuleList() can return null
instead of an empty list?

Looking at the code of RecipeImpl it seems to be inconsistent.

a) getRuleList() returns null if there are no rules.

public RuleList getRuleList()

{ return ruleList; }

b) getRuleNames() and listRuleIDs() returns and empty list if there are
no rules.

@Override
public List<UriRef> listRuleIDs() {
if (ruleList != null && !ruleList.isEmpty())

{ ... }

else

{ return Collections.emptyList(); }

}

Personally I prefer getRuleList() to also always return a possibly empty
list.

Regards,

Minto