Stanbol
  1. Stanbol
  2. STANBOL-490

IndexedGraphTest takes too much time

    Details

      Description

      The test org.apache.stanbol.commons.indexedgraph.IndexedGraphTest takes too much time (1062ms on my machine). This is in conflict with the goal that unit tests should be fast to keep the build process efficient for developers, It seems that this is more a performance than a unit test.

      This test should be moved to the integration tests.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        10d 6h 32m 1 Rupert Westenthaler 24/Feb/12 13:38
        Resolved Resolved Closed Closed
        75d 9m 1 Fabian Christ 09/May/12 14:48
        Fabian Christ made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Fabian Christ made changes -
        Fix Version/s 0.9.0-incubating [ 12317604 ]
        Rupert Westenthaler made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Rupert Westenthaler added a comment -

        after revision #1293241 the test only uses 100 instead of 1000 iterations.

        Show
        Rupert Westenthaler added a comment - after revision #1293241 the test only uses 100 instead of 1000 iterations.
        Hide
        Rupert Westenthaler added a comment -

        Hi Fabian

        This is related to the "testPerformance" unit test. I had already considered to deactivate this test because performance testing is not important to be done during unit test. However this test does also very nicely validate that the the filtered iterators returned by the IndexedGraph implementation return the same triples as the SimpleMGraph implementation used as a reference.

        Such tests are also included in the default test set provided by Clerezza, but in this case they are performed on a very small set of triples and therefore may parse by accident. This tests uses currently a Graph with 100k triples and a randomly generated set of iterations what makes it very unlikely to miss issues in the implementation of the Comparators used for the internal indexes.

        Because of that I suggest that you adapt the following parameters of the "testPerformance" until you reach an acceptable execution time:

        int iterations = 1000;
        int graphsize = 100000;
        [..]
        TestCase testCase = new TestCase(sg, 100, 5, 100);

        You can safely change all parameters. However I would not reduce the third parameter ('5') to TestCase.

        best
        Rupert

        Show
        Rupert Westenthaler added a comment - Hi Fabian This is related to the "testPerformance" unit test. I had already considered to deactivate this test because performance testing is not important to be done during unit test. However this test does also very nicely validate that the the filtered iterators returned by the IndexedGraph implementation return the same triples as the SimpleMGraph implementation used as a reference. Such tests are also included in the default test set provided by Clerezza, but in this case they are performed on a very small set of triples and therefore may parse by accident. This tests uses currently a Graph with 100k triples and a randomly generated set of iterations what makes it very unlikely to miss issues in the implementation of the Comparators used for the internal indexes. Because of that I suggest that you adapt the following parameters of the "testPerformance" until you reach an acceptable execution time: int iterations = 1000; int graphsize = 100000; [..] TestCase testCase = new TestCase(sg, 100, 5, 100); You can safely change all parameters. However I would not reduce the third parameter ('5') to TestCase. best Rupert
        Fabian Christ created issue -

          People

          • Assignee:
            Rupert Westenthaler
            Reporter:
            Fabian Christ
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development