[SSHD-861] Handling extra '@' present in username,password while creating SftpFileSystemProvider.createFileSystemURI

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.2.0
• Labels: easyfix
• Environment: Dell Laptop, ; Intel i5-7200U 8gb RAM ; Windows 10 pro 64-bit
• Flags: Patch, Important
• Assignee: Lyor Goldstein
• Reporter: Mohammed Salman
• Created: 08/Nov/18 17:33
• Updated: 08/Jun/20 13:34
• Resolved: 11/Nov/18 16:51

Description

From the documentation mina-sshd ,

URI uri = SftpFileSystemProvider.createFileSystemURI(host, port, username, password);

if username or password parameters contain a character '@' , for example,

 

 

username = "J@ck";
password = "d@Ripper"; 

then the resulting URI has hostname null ,because

SftpFileSystemProvider.createSystemURI

internally uses

URI.create(sb.ToString) 

which does not handle this. To solve this, URI constructor should be used as suggested in the answer here .

 

String userInfo = userName + ":" + password; String path = remoteDirectory + filename; // Need a '/' between them? URI sftpUri = new URI("sftp", userInfo, remoteServerAddress, portNo, null, null, null);