[SSHD-849] Possible race condition for local port forwarding channels

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.2.0
• Fix Version/s: 2.2.0
• Flags: Patch
• Assignee: Lyor Goldstein
• Reporter: Roberto Deandrea
• Created: 15/Oct/18 14:32
• Updated: 08/Jun/20 13:34
• Resolved: 06/Nov/18 14:50

Description

Hi Lyor,

We found another critical race condition sending data through local port forwarding channels that causes loosing data bytes sent by client to target server.

As soon as possible I will open a pull request with our potential changes to fix this issue.

I let you know when done because I would like to know your feedback.

 Hi Lyor,
We made some code changes to your proposed solution based on ClientChannelPendingMessageQueue.

You can find our commit at https://github.com/robertodeandrea/mina-sshd/commit/4523138ee2b4efa483bc956e8769eafb13eff05d

Can you review our code and give us feedback ?
If it satisfies you can you merge it in Apache SSHD master repository ?

Our definitive working code is at https://github.com/robertodeandrea/mina-sshd/commit/c381e522dc254387009d82612dc15f0c584dece6

Cheers.
Roberto

Cheers

Roberto

The code changes against master code are :
https://github.com/robertodeandrea/myclone/commit/0602840140ce82f51446b0d5a05fb409e730adad

 

Issue Links

• links to: GitHub Pull Request #70
• links to: GitHub Pull Request #72
• links to: GitHub Pull Request #79
• links to: GitHub Pull Request #80
• links to: GitHub Pull Request #80