[SSHD-838] Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.1.0
• Labels: important listener logging
• Flags: Patch
• Assignee: Lyor Goldstein
• Reporter: jpalacios
• Created: 31/Jul/18 06:28
• Updated: 08/Jun/20 13:35
• Resolved: 05/Aug/18 16:35

Description

As discussed in SSHD-833, it appears that when a client disconnects before the handshake completes there's some pretty loud logging coming from the Nio2Acceptor.AcceptCompletionHandler#okToReaccept.

The entire message is logged at WARN level. Also, several lines from the stack trace are logged individually at the same level.

We feel this much logging at WARN level will be too much noise for system administrators who might think there's something wrong with the system. We propose:

1. Changing the log level to DEBUG / FINE
2. Logging the stacktrace in a single message

Issue Links

• links to: GitHub Pull Request #65