Uploaded image for project: 'MINA SSHD'
  1. MINA SSHD
  2. SSHD-838

Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.1
    • Flags:
      Patch

      Description

      As discussed in SSHD-833, it appears that when a client disconnects before the handshake completes there's some pretty loud logging coming from the Nio2Acceptor.AcceptCompletionHandler#okToReaccept.

      The entire message is logged at WARN level. Also, several lines from the stack trace are logged individually at the same level.

      We feel this much logging at WARN level will be too much noise for system administrators who might think there's something wrong with the system. We propose:

      1. Changing the log level to DEBUG / FINE
      2. Logging the stacktrace in a single message

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lgoldstein Goldstein Lyor
                Reporter:
                jpalacios jpalacios
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: