[SSHD-370] SSHD-CORE component declaring dependencies for OSGi as optional

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Won't Fix
• Environment: OSGi container with sshd-core bundle
• Assignee: Unassigned
• Reporter: Maros Marsalek
• Created: 13/Nov/14 15:32
• Updated: 24/Feb/15 09:07
• Resolved: 18/Nov/14 07:51

Description

The import-package instructions that are present in the MANIFEST for sshd-core are declared as optional. Is this correct ? I use the class PEMGeneratorHostKeyProvider to generate/read the PEM file. This class directly uses classes from bouncycastle bundle. In case the bouncycastle bundle is not present or resolved I get following exception:

2014-11-11 11:10:41,423 | WARN | o-group-thread-1 | Nio2Acceptor | 208 - org.apache.sshd.core - 0.12.0 | Caught exception while accepting incoming connection
java.lang.NoClassDefFoundError: org/bouncycastle/openssl/PEMParser
at org.apache.sshd.server.keyprovider.PEMGeneratorHostKeyProvider.doReadKeyPair(PEMGeneratorHostKeyProvider.java:58)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.server.keyprovider.AbstractGeneratorHostKeyProvider.readKeyPair(AbstractGeneratorHostKeyProvider.java:128)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.server.keyprovider.AbstractGeneratorHostKeyProvider.loadKeys(AbstractGeneratorHostKeyProvider.java:108)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.common.keyprovider.AbstractKeyPairProvider.getKeyTypes(AbstractKeyPairProvider.java:53)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.server.session.ServerSession.sendKexInit(ServerSession.java:127)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.server.session.ServerSession.<init>(ServerSession.java:60)[208:org.apache.sshd.core:0.12.0]
at org.apache.sshd.server.session.SessionFactory.doCreateSession(SessionFactory.java:43)

I would expect the bundle to fail in the dependency resolution phase to prevent runtime errors.

I am on version 0.12 but I think this is present in the newer version as well.