[SSHD-300] Double public key authentication

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10.1
• Fix Version/s: 0.11.0
• Assignee: Guillaume Nodet
• Reporter: David Ostrovsky
• Created: 15/Mar/14 09:04
• Updated: 14/Apr/14 11:38
• Resolved: 17/Mar/14 12:08

Description

PublickeyAuthenticator.authenticate() method is called twice, even though the first call of this method already authenticated the user and returned true.

This is a preformance issue, as server may need to hit database/caches to retrieve the list of public key(s) for the user to preform the check against.

Or the authenticate() implementation needs to be adjusted to preform the check that the user was alreay authenticated.

Reproducer patch is attaced. The problem only occurs when the test is called from open SSH client. Own SSHD's client works as expected.

To reproduce, start the attached unit test as Java application, and issue the command:

ssh localhost -p 29418 -l joe

[1] https://gerrit-review.googlesource.com/55193