MINA SSHD
  1. MINA SSHD
  2. SSHD-162

Allow the configuration of InvertedShellWrapper's thread pool

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.6.0
    • Fix Version/s: 0.7.0
    • Labels:

      Description

      InvertedShellWrapper spawns a new thread for pumping the shell I/O. It would be more flexible to allow the specification of an Executor, so that the user can customise how the new thread is allocated (for example, to allow its allocation from a cached thread pool or a pool with a bounded number of threads).

      1. SSHD-162.patch
        2 kB
        Pierre-Etienne Poirot

        Activity

        Pierre-Etienne Poirot created issue -
        Pierre-Etienne Poirot made changes -
        Field Original Value New Value
        Description {{InvertedShellWrapper}} spawns a new thread for pumping the shell I/O. It would be more flexible to allow the specification of an {{Executor}}, so that the user can customise how the new thread is allocated (for example, to allow its allocation from a cached thread pool or a pool with a bounded number of threads). InvertedShellWrapper spawns a new thread for pumping the shell I/O. It would be more flexible to allow the specification of an Executor, so that the user can customise how the new thread is allocated (for example, to allow its allocation from a cached thread pool or a pool with a bounded number of threads).
        Pierre-Etienne Poirot made changes -
        Attachment SSHD-162.patch [ 12525036 ]
        Hide
        Pierre-Etienne Poirot added a comment -

        attached patch

        Show
        Pierre-Etienne Poirot added a comment - attached patch
        Pierre-Etienne Poirot made changes -
        Attachment SSHD-162.patch [ 12525036 ]
        Hide
        Pierre-Etienne Poirot added a comment - - edited

        Updated patch:

        • since we are not reusing the executor when it is not passed by the creator of the InvertedShellWrapper, use a fixed thread pool of one thread instead of a cached pool
        • use a NamePreservingRunnable to set the name of the Thread while running the IO pumps
        Show
        Pierre-Etienne Poirot added a comment - - edited Updated patch: since we are not reusing the executor when it is not passed by the creator of the InvertedShellWrapper, use a fixed thread pool of one thread instead of a cached pool use a NamePreservingRunnable to set the name of the Thread while running the IO pumps
        Pierre-Etienne Poirot made changes -
        Attachment SSHD-162.patch [ 12525718 ]
        Hide
        Guillaume Nodet added a comment -

        Patch applied. Thx a ton.

        Show
        Guillaume Nodet added a comment - Patch applied. Thx a ton.
        Guillaume Nodet made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Guillaume Nodet [ gnt ]
        Fix Version/s 0.7.0 [ 12317953 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Guillaume Nodet
            Reporter:
            Pierre-Etienne Poirot
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development