Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:
      None

      Description

      Framework's metadata can be also changed, so we should provide the upgrader also for framework itself.

      1. SQOOP-998.patch
        17 kB
        Hari Shreedharan
      2. SQOOP-998-1.patch
        16 kB
        Hari Shreedharan

        Issue Links

          Activity

          Hide
          Hari Shreedharan added a comment -

          Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.

          Show
          Hari Shreedharan added a comment - Added framework upgrade code. I know some of this can be refactored to remove the code duplication with the connector upgrade. I will look into that at a later stage.
          Hide
          Hari Shreedharan added a comment -

          There is some code duplication in the MetadataUpgrader for the Framework - I don't think that should be removed, since the metdata upgraders should be completely self sufficient and should not depend on implementations in the base class.

          I would like to keep that as an interface, but I am leaving it as an abstract class only because we can add methods with no-op implementations later if the need be.

          (I am open to moving the doUpgrade method to a Utils class at a later stage).

          Show
          Hari Shreedharan added a comment - There is some code duplication in the MetadataUpgrader for the Framework - I don't think that should be removed, since the metdata upgraders should be completely self sufficient and should not depend on implementations in the base class. I would like to keep that as an interface, but I am leaving it as an abstract class only because we can add methods with no-op implementations later if the need be. (I am open to moving the doUpgrade method to a Utils class at a later stage).
          Hide
          Hari Shreedharan added a comment -

          Removed unused/redundant imports.

          Show
          Hari Shreedharan added a comment - Removed unused/redundant imports.
          Hide
          Jarek Jarcec Cecho added a comment -
          Show
          Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=66dd617da2d866df02f430923d82d76091e10aa7 Thank you Hari for your time and effort! Jarcec
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #275 (See https://builds.apache.org/job/Sqoop2-hadoop200/275/)
          SQOOP-998: Sqoop2: Upgrade: Add framework upgrader (Revision 66dd617da2d866df02f430923d82d76091e10aa7)

          Result = FAILURE
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=66dd617da2d866df02f430923d82d76091e10aa7
          Files :

          • core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
          • core/src/main/java/org/apache/sqoop/repository/Repository.java
          • repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
          • repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
          • core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #275 (See https://builds.apache.org/job/Sqoop2-hadoop200/275/ ) SQOOP-998 : Sqoop2: Upgrade: Add framework upgrader (Revision 66dd617da2d866df02f430923d82d76091e10aa7) Result = FAILURE jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=66dd617da2d866df02f430923d82d76091e10aa7 Files : core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java core/src/main/java/org/apache/sqoop/repository/Repository.java repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #276 (See https://builds.apache.org/job/Sqoop2-hadoop100/276/)
          SQOOP-998: Sqoop2: Upgrade: Add framework upgrader (Revision 66dd617da2d866df02f430923d82d76091e10aa7)

          Result = FAILURE
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=66dd617da2d866df02f430923d82d76091e10aa7
          Files :

          • core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
          • repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
          • core/src/main/java/org/apache/sqoop/repository/Repository.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
          • repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
          • core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #276 (See https://builds.apache.org/job/Sqoop2-hadoop100/276/ ) SQOOP-998 : Sqoop2: Upgrade: Add framework upgrader (Revision 66dd617da2d866df02f430923d82d76091e10aa7) Result = FAILURE jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=66dd617da2d866df02f430923d82d76091e10aa7 Files : core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java core/src/main/java/org/apache/sqoop/repository/Repository.java core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
          Hide
          Jarek Jarcec Cecho added a comment -

          The build failures are more Jenkins issues than a real problem, JIRA SQOOP-1026 was created to keep track of that.

          Show
          Jarek Jarcec Cecho added a comment - The build failures are more Jenkins issues than a real problem, JIRA SQOOP-1026 was created to keep track of that.

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development