Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-995

Sqoop2: Add cloning ability to model classes

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.2
    • Fix Version/s: 1.99.3
    • Component/s: None
    • Labels:
      None

      Description

      We've introduced quick "cloneForms" method during SQOOP-652. I think that we should refactore the method by introducing cloning ability to the model classes themselves.

      1. SQOOP-995.patch
        11 kB
        Vasanth kumar RJ
      2. SQOOP-995.patch
        21 kB
        Vasanth kumar RJ

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #293 (See https://builds.apache.org/job/Sqoop2-hadoop200/293/)
          SQOOP-995: Sqoop2: Add cloning ability to model classes (Revision 94c91efd3bfc87123ec11589aa32812a23101d3e)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=94c91efd3bfc87123ec11589aa32812a23101d3e
          Files :

          • common/src/main/java/org/apache/sqoop/model/MStringInput.java
          • common/src/main/java/org/apache/sqoop/model/MConnector.java
          • common/src/main/java/org/apache/sqoop/model/MFormList.java
          • common/src/main/java/org/apache/sqoop/model/MJob.java
          • common/src/main/java/org/apache/sqoop/model/MClonable.java
          • common/src/main/java/org/apache/sqoop/model/MJobForms.java
          • common/src/test/java/org/apache/sqoop/model/TestMConnector.java
          • common/src/main/java/org/apache/sqoop/model/MConnection.java
          • common/src/main/java/org/apache/sqoop/model/MFramework.java
          • common/src/test/java/org/apache/sqoop/model/TestMJob.java
          • common/src/main/java/org/apache/sqoop/model/MEnumInput.java
          • common/src/main/java/org/apache/sqoop/model/MInput.java
          • common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
          • common/src/test/java/org/apache/sqoop/model/TestMConnection.java
          • common/src/main/java/org/apache/sqoop/model/MMapInput.java
          • common/src/main/java/org/apache/sqoop/model/MForm.java
          • common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
          Show
          hudson Hudson added a comment - Integrated in Sqoop2-hadoop200 #293 (See https://builds.apache.org/job/Sqoop2-hadoop200/293/ ) SQOOP-995 : Sqoop2: Add cloning ability to model classes (Revision 94c91efd3bfc87123ec11589aa32812a23101d3e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=94c91efd3bfc87123ec11589aa32812a23101d3e Files : common/src/main/java/org/apache/sqoop/model/MStringInput.java common/src/main/java/org/apache/sqoop/model/MConnector.java common/src/main/java/org/apache/sqoop/model/MFormList.java common/src/main/java/org/apache/sqoop/model/MJob.java common/src/main/java/org/apache/sqoop/model/MClonable.java common/src/main/java/org/apache/sqoop/model/MJobForms.java common/src/test/java/org/apache/sqoop/model/TestMConnector.java common/src/main/java/org/apache/sqoop/model/MConnection.java common/src/main/java/org/apache/sqoop/model/MFramework.java common/src/test/java/org/apache/sqoop/model/TestMJob.java common/src/main/java/org/apache/sqoop/model/MEnumInput.java common/src/main/java/org/apache/sqoop/model/MInput.java common/src/main/java/org/apache/sqoop/model/MIntegerInput.java common/src/test/java/org/apache/sqoop/model/TestMConnection.java common/src/main/java/org/apache/sqoop/model/MMapInput.java common/src/main/java/org/apache/sqoop/model/MForm.java common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
          Hide
          hudson Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #289 (See https://builds.apache.org/job/Sqoop2-hadoop100/289/)
          SQOOP-995: Sqoop2: Add cloning ability to model classes (Revision 94c91efd3bfc87123ec11589aa32812a23101d3e)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=94c91efd3bfc87123ec11589aa32812a23101d3e
          Files :

          • common/src/test/java/org/apache/sqoop/model/TestMJob.java
          • common/src/main/java/org/apache/sqoop/model/MFramework.java
          • common/src/main/java/org/apache/sqoop/model/MStringInput.java
          • common/src/main/java/org/apache/sqoop/model/MEnumInput.java
          • common/src/main/java/org/apache/sqoop/model/MClonable.java
          • common/src/main/java/org/apache/sqoop/model/MIntegerInput.java
          • common/src/main/java/org/apache/sqoop/model/MJob.java
          • common/src/test/java/org/apache/sqoop/model/TestMConnection.java
          • common/src/main/java/org/apache/sqoop/model/MFormList.java
          • common/src/main/java/org/apache/sqoop/model/MMapInput.java
          • common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
          • common/src/main/java/org/apache/sqoop/model/MForm.java
          • common/src/main/java/org/apache/sqoop/model/MJobForms.java
          • common/src/main/java/org/apache/sqoop/model/MInput.java
          • common/src/test/java/org/apache/sqoop/model/TestMConnector.java
          • common/src/main/java/org/apache/sqoop/model/MConnection.java
          • common/src/main/java/org/apache/sqoop/model/MConnector.java
          Show
          hudson Hudson added a comment - Integrated in Sqoop2-hadoop100 #289 (See https://builds.apache.org/job/Sqoop2-hadoop100/289/ ) SQOOP-995 : Sqoop2: Add cloning ability to model classes (Revision 94c91efd3bfc87123ec11589aa32812a23101d3e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=94c91efd3bfc87123ec11589aa32812a23101d3e Files : common/src/test/java/org/apache/sqoop/model/TestMJob.java common/src/main/java/org/apache/sqoop/model/MFramework.java common/src/main/java/org/apache/sqoop/model/MStringInput.java common/src/main/java/org/apache/sqoop/model/MEnumInput.java common/src/main/java/org/apache/sqoop/model/MClonable.java common/src/main/java/org/apache/sqoop/model/MIntegerInput.java common/src/main/java/org/apache/sqoop/model/MJob.java common/src/test/java/org/apache/sqoop/model/TestMConnection.java common/src/main/java/org/apache/sqoop/model/MFormList.java common/src/main/java/org/apache/sqoop/model/MMapInput.java common/src/main/java/org/apache/sqoop/model/MConnectionForms.java common/src/main/java/org/apache/sqoop/model/MForm.java common/src/main/java/org/apache/sqoop/model/MJobForms.java common/src/main/java/org/apache/sqoop/model/MInput.java common/src/test/java/org/apache/sqoop/model/TestMConnector.java common/src/main/java/org/apache/sqoop/model/MConnection.java common/src/main/java/org/apache/sqoop/model/MConnector.java
          Show
          jarcec Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=94c91efd3bfc87123ec11589aa32812a23101d3e Thank you Vasanth! Jarcec
          Hide
          jarcec Jarek Jarcec Cecho added a comment -

          Hi Vasanth kumar RJ,
          thank you for picking up this one. I've left few comments on the review board. I think that copying values should be configurable because we might need both behaviorism (e.g. sometimes create copy with values, sometimes without).

          Jarcec

          Show
          jarcec Jarek Jarcec Cecho added a comment - Hi Vasanth kumar RJ , thank you for picking up this one. I've left few comments on the review board. I think that copying values should be configurable because we might need both behaviorism (e.g. sometimes create copy with values, sometimes without). Jarcec
          Hide
          vasanthkumar Vasanth kumar RJ added a comment -

          Hi Jarek,

          For cloning the model classes containing forms, need to preserve value of form input as well?

          Cloning by creating copy constructor. In case if preserve form input's value, can we have cloning with and without form input value?

          Kindly suggest.

          Thanks,
          Vasanth kumar

          Show
          vasanthkumar Vasanth kumar RJ added a comment - Hi Jarek, For cloning the model classes containing forms, need to preserve value of form input as well? Cloning by creating copy constructor. In case if preserve form input's value, can we have cloning with and without form input value? Kindly suggest. Thanks, Vasanth kumar

            People

            • Assignee:
              vasanthkumar Vasanth kumar RJ
              Reporter:
              jarcec Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development