Sqoop
  1. Sqoop
  2. SQOOP-942

Sqoop2: Refactore code repetition in SqoopRequests objects

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:
      None

      Description

      We currently have code repetition in applying validations in SqoopRequest object. We should refactore that into shared method. Also in addition those methods are using FormUtils from shell. As we are inclining of separating shell into it's own package, we should also move the functionality accordingly.

      1. bugSQOOP-942.patch
        7 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Jarek Jarcec Cecho created issue -
          Jarek Jarcec Cecho made changes -
          Field Original Value New Value
          Link This issue is blocked by SQOOP-918 [ SQOOP-918 ]
          Jarek Jarcec Cecho made changes -
          Remote Link This issue links to "Review board (Web Link)" [ 12101 ]
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-942.patch [ 12574084 ]
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Jarek Jarcec Cecho [ jarcec ]
          Fix Version/s 1.99.2 [ 12323640 ]
          Show
          Kathleen Ting added a comment - Thanks Jarcec for your contribution. The patch is in: https://git-wip-us.apache.org/repos/asf/sqoop/repo?p=sqoop.git;a=commit;h=27271af13f16cdfc6b77e5ba8e06adea21558dd4
          Kathleen Ting made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #242 (See https://builds.apache.org/job/Sqoop2-hadoop200/242/)
          SQOOP-942: Sqoop2: Refactor code repetition in SqoopRequests objects (Revision 27271af13f16cdfc6b77e5ba8e06adea21558dd4)

          Result = SUCCESS
          kathleen : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=27271af13f16cdfc6b77e5ba8e06adea21558dd4
          Files :

          • client/src/main/java/org/apache/sqoop/client/SqoopClient.java
          • client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #242 (See https://builds.apache.org/job/Sqoop2-hadoop200/242/ ) SQOOP-942 : Sqoop2: Refactor code repetition in SqoopRequests objects (Revision 27271af13f16cdfc6b77e5ba8e06adea21558dd4) Result = SUCCESS kathleen : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=27271af13f16cdfc6b77e5ba8e06adea21558dd4 Files : client/src/main/java/org/apache/sqoop/client/SqoopClient.java client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #241 (See https://builds.apache.org/job/Sqoop2-hadoop100/241/)
          SQOOP-942: Sqoop2: Refactor code repetition in SqoopRequests objects (Revision 27271af13f16cdfc6b77e5ba8e06adea21558dd4)

          Result = ABORTED
          kathleen : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=27271af13f16cdfc6b77e5ba8e06adea21558dd4
          Files :

          • client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
          • client/src/main/java/org/apache/sqoop/client/SqoopClient.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #241 (See https://builds.apache.org/job/Sqoop2-hadoop100/241/ ) SQOOP-942 : Sqoop2: Refactor code repetition in SqoopRequests objects (Revision 27271af13f16cdfc6b77e5ba8e06adea21558dd4) Result = ABORTED kathleen : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=27271af13f16cdfc6b77e5ba8e06adea21558dd4 Files : client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java client/src/main/java/org/apache/sqoop/client/SqoopClient.java
          Hide
          Jarek Jarcec Cecho added a comment -

          The aborted build for hadoop 100 profile seems to be some sort of Jenkins issue.

          Show
          Jarek Jarcec Cecho added a comment - The aborted build for hadoop 100 profile seems to be some sort of Jenkins issue.
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6d 21h 49m 1 Jarek Jarcec Cecho 17/Mar/13 21:49
          Patch Available Patch Available Resolved Resolved
          8d 9h 54m 1 Kathleen Ting 26/Mar/13 07:43

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development