Sqoop
  1. Sqoop
  2. SQOOP-941

Sqoop2: Do not send sensitive values from server to client

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:
      None

      Description

      We're currently not displaying Inputs defined as sensitive on the client side. However server is still sending them to the client. I believe that we should stop doing that as anyone can directly connect to the REST interface and fetch them.

      1. sqoop-941.patch
        20 kB
        Abraham Elmahrek

        Issue Links

          Activity

          Jarek Jarcec Cecho created issue -
          Hide
          Jarek Jarcec Cecho added a comment -

          Setting to "Patch available" so that it will show up in the review queue.

          Show
          Jarek Jarcec Cecho added a comment - Setting to "Patch available" so that it will show up in the review queue.
          Jarek Jarcec Cecho made changes -
          Field Original Value New Value
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Abraham Elmahrek [ abec ]
          Jarek Jarcec Cecho made changes -
          Fix Version/s 1.99.2 [ 12323640 ]
          Jarek Jarcec Cecho made changes -
          Remote Link This issue links to "Review board (Web Link)" [ 12082 ]
          Hide
          Abraham Elmahrek added a comment -

          Attached patch

          Show
          Abraham Elmahrek added a comment - Attached patch
          Abraham Elmahrek made changes -
          Attachment sqoop-941.patch [ 12573922 ]
          Hide
          Jarek Jarcec Cecho added a comment -
          Show
          Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=b49b71235d655514eb581f21fc72e4ec0841d3d0 Thank you Abe for your contribution! Jarcec
          Jarek Jarcec Cecho made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #238 (See https://builds.apache.org/job/Sqoop2-hadoop100/238/)
          SQOOP-941: Sqoop2: Do not send sensitive values from server to client (Revision b49b71235d655514eb581f21fc72e4ec0841d3d0)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=b49b71235d655514eb581f21fc72e4ec0841d3d0
          Files :

          • client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
          • common/src/main/java/org/apache/sqoop/json/ThrowableBean.java
          • common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java
          • common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
          • common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
          • common/src/test/java/org/apache/sqoop/json/TestUtil.java
          • common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
          • common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
          • common/src/main/java/org/apache/sqoop/json/VersionBean.java
          • common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
          • common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java
          • common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
          • common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
          • common/src/main/java/org/apache/sqoop/json/JsonBean.java
          • common/src/main/java/org/apache/sqoop/json/JobBean.java
          • server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java
          • common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
          • client/src/main/java/org/apache/sqoop/client/request/JobRequest.java
          • common/src/test/java/org/apache/sqoop/json/TestJobBean.java
          • common/src/main/java/org/apache/sqoop/json/FrameworkBean.java
          • common/src/main/java/org/apache/sqoop/json/ValidationBean.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #238 (See https://builds.apache.org/job/Sqoop2-hadoop100/238/ ) SQOOP-941 : Sqoop2: Do not send sensitive values from server to client (Revision b49b71235d655514eb581f21fc72e4ec0841d3d0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=b49b71235d655514eb581f21fc72e4ec0841d3d0 Files : client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java common/src/main/java/org/apache/sqoop/json/ThrowableBean.java common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java common/src/test/java/org/apache/sqoop/json/TestValidationBean.java common/src/main/java/org/apache/sqoop/json/ConnectorBean.java common/src/test/java/org/apache/sqoop/json/TestUtil.java common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java common/src/main/java/org/apache/sqoop/json/SubmissionBean.java common/src/main/java/org/apache/sqoop/json/VersionBean.java common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java common/src/main/java/org/apache/sqoop/json/ConnectionBean.java common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java common/src/main/java/org/apache/sqoop/json/JsonBean.java common/src/main/java/org/apache/sqoop/json/JobBean.java server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java client/src/main/java/org/apache/sqoop/client/request/JobRequest.java common/src/test/java/org/apache/sqoop/json/TestJobBean.java common/src/main/java/org/apache/sqoop/json/FrameworkBean.java common/src/main/java/org/apache/sqoop/json/ValidationBean.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #240 (See https://builds.apache.org/job/Sqoop2-hadoop200/240/)
          SQOOP-941: Sqoop2: Do not send sensitive values from server to client (Revision b49b71235d655514eb581f21fc72e4ec0841d3d0)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=b49b71235d655514eb581f21fc72e4ec0841d3d0
          Files :

          • common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
          • common/src/main/java/org/apache/sqoop/json/FrameworkBean.java
          • common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
          • common/src/test/java/org/apache/sqoop/json/TestJobBean.java
          • common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
          • client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
          • common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java
          • client/src/main/java/org/apache/sqoop/client/request/JobRequest.java
          • common/src/main/java/org/apache/sqoop/json/VersionBean.java
          • common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java
          • common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java
          • common/src/main/java/org/apache/sqoop/json/JsonBean.java
          • server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java
          • common/src/test/java/org/apache/sqoop/json/TestUtil.java
          • common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
          • common/src/test/java/org/apache/sqoop/json/TestValidationBean.java
          • common/src/main/java/org/apache/sqoop/json/JobBean.java
          • common/src/main/java/org/apache/sqoop/json/ThrowableBean.java
          • common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
          • common/src/main/java/org/apache/sqoop/json/ConnectorBean.java
          • common/src/main/java/org/apache/sqoop/json/ValidationBean.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #240 (See https://builds.apache.org/job/Sqoop2-hadoop200/240/ ) SQOOP-941 : Sqoop2: Do not send sensitive values from server to client (Revision b49b71235d655514eb581f21fc72e4ec0841d3d0) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=b49b71235d655514eb581f21fc72e4ec0841d3d0 Files : common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java common/src/main/java/org/apache/sqoop/json/FrameworkBean.java common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java common/src/test/java/org/apache/sqoop/json/TestJobBean.java common/src/main/java/org/apache/sqoop/json/SubmissionBean.java client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java common/src/test/java/org/apache/sqoop/json/TestThrowableBean.java client/src/main/java/org/apache/sqoop/client/request/JobRequest.java common/src/main/java/org/apache/sqoop/json/VersionBean.java common/src/test/java/org/apache/sqoop/json/TestFrameworkBean.java common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java common/src/main/java/org/apache/sqoop/json/JsonBean.java server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java common/src/test/java/org/apache/sqoop/json/TestUtil.java common/src/main/java/org/apache/sqoop/json/ConnectionBean.java common/src/test/java/org/apache/sqoop/json/TestValidationBean.java common/src/main/java/org/apache/sqoop/json/JobBean.java common/src/main/java/org/apache/sqoop/json/ThrowableBean.java common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java common/src/main/java/org/apache/sqoop/json/ConnectorBean.java common/src/main/java/org/apache/sqoop/json/ValidationBean.java
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          4d 11h 5m 1 Jarek Jarcec Cecho 15/Mar/13 04:45
          Patch Available Patch Available Resolved Resolved
          8d 10h 20m 1 Jarek Jarcec Cecho 23/Mar/13 15:05

            People

            • Assignee:
              Abraham Elmahrek
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development