Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-928

PostgresqlManager should rollback any pending changes instead of commit when closing connections

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 1.4.4
    • Component/s: None
    • Labels:
      None
    • Environment:

      Postgresql DB

      Description

      While closing the connection acquired with getConnection, Postgresql Manager implementation commits any pending changes instead of rolling back.
      If autocommit is off, then the "users" of the connection should commit any persistent changes and not depend on close() calling commit.

      1. SQOOP-928.patch
        0.9 kB
        Venkat Ranganathan

        Activity

        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        Patch with one line fix

        Show
        venkatnrangan Venkat Ranganathan added a comment - Patch with one line fix
        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        Ran postgresql export and import tests

        Show
        venkatnrangan Venkat Ranganathan added a comment - Ran postgresql export and import tests
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        It's quite simple patch, so I'm giving my +1 here.

        Show
        jarcec Jarek Jarcec Cecho added a comment - It's quite simple patch, so I'm giving my +1 here.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -
        Show
        jarcec Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=34bdf07bc847a727a9508fd0ed071635d644721e Thank you Venkat for your contribution! Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #579 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/579/)
        SQOOP-928: PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e
        Files :

        • src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #579 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/579/ ) SQOOP-928 : PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e Files : src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #576 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/576/)
        SQOOP-928: PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e
        Files :

        • src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #576 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/576/ ) SQOOP-928 : PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e Files : src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #790 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/790/)
        SQOOP-928: PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e
        Files :

        • src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #790 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/790/ ) SQOOP-928 : PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e Files : src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #590 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/590/)
        SQOOP-928: PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e
        Files :

        • src/java/org/apache/sqoop/manager/PostgresqlManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #590 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/590/ ) SQOOP-928 : PostgresqlManager should rollback any pending changes instead of commit when closing connections (Revision 34bdf07bc847a727a9508fd0ed071635d644721e) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=34bdf07bc847a727a9508fd0ed071635d644721e Files : src/java/org/apache/sqoop/manager/PostgresqlManager.java

          People

          • Assignee:
            venkatnrangan Venkat Ranganathan
            Reporter:
            venkatnrangan Venkat Ranganathan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development