Sqoop
  1. Sqoop
  2. SQOOP-888

Sqoop2: Move out checking of special condition token to Validator in Generic JDBC Manager

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:
      None

      Description

      Checking supplied query is correct or not should be done on Validator side, so that we can fail as soon as possible and not at the job submission time.

      1. bugSQOOP-888.patch
        2 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #194 (See https://builds.apache.org/job/Sqoop2-hadoop100/194/)
          SQOOP-888: Move out checking of special condition token to Validator in Generic JDBC Manager (Revision 6eb27b821d873c92e20d71260293f4a842b804dc)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=6eb27b821d873c92e20d71260293f4a842b804dc
          Files :

          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #194 (See https://builds.apache.org/job/Sqoop2-hadoop100/194/ ) SQOOP-888 : Move out checking of special condition token to Validator in Generic JDBC Manager (Revision 6eb27b821d873c92e20d71260293f4a842b804dc) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=6eb27b821d873c92e20d71260293f4a842b804dc Files : connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #208 (See https://builds.apache.org/job/Sqoop2-hadoop200/208/)
          SQOOP-888: Move out checking of special condition token to Validator in Generic JDBC Manager (Revision 6eb27b821d873c92e20d71260293f4a842b804dc)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=6eb27b821d873c92e20d71260293f4a842b804dc
          Files :

          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #208 (See https://builds.apache.org/job/Sqoop2-hadoop200/208/ ) SQOOP-888 : Move out checking of special condition token to Validator in Generic JDBC Manager (Revision 6eb27b821d873c92e20d71260293f4a842b804dc) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=6eb27b821d873c92e20d71260293f4a842b804dc Files : connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
          Hide
          Cheolsoo Park added a comment -

          +1.

          Committed to sqoop2. Thanks Jarcec!

          Show
          Cheolsoo Park added a comment - +1. Committed to sqoop2. Thanks Jarcec!

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development