Sqoop
  1. Sqoop
  2. SQOOP-887

Sqoop2: Move string constants from FormDisplayer to resource file

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:

      Description

      Class FormDisplayer have a lot of English string constants. I believe that we should move them out to resource file for subsequent translation.

      1. SQOOP-887.patch
        8 kB
        Vasanth kumar RJ

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #227 (See https://builds.apache.org/job/Sqoop2-hadoop200/227/)
          SQOOP-887: Sqoop2: Move string constants from FormDisplayer to resource file (Revision daccebac519f65d5d8a62e6be421ff1e382ffa06)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=daccebac519f65d5d8a62e6be421ff1e382ffa06
          Files :

          • client/src/main/java/org/apache/sqoop/client/core/Constants.java
          • client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
          • client/src/main/resources/client-resource.properties
          • client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #227 (See https://builds.apache.org/job/Sqoop2-hadoop200/227/ ) SQOOP-887 : Sqoop2: Move string constants from FormDisplayer to resource file (Revision daccebac519f65d5d8a62e6be421ff1e382ffa06) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=daccebac519f65d5d8a62e6be421ff1e382ffa06 Files : client/src/main/java/org/apache/sqoop/client/core/Constants.java client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java client/src/main/resources/client-resource.properties client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #226 (See https://builds.apache.org/job/Sqoop2-hadoop100/226/)
          SQOOP-887: Sqoop2: Move string constants from FormDisplayer to resource file (Revision daccebac519f65d5d8a62e6be421ff1e382ffa06)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=daccebac519f65d5d8a62e6be421ff1e382ffa06
          Files :

          • client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
          • client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
          • client/src/main/java/org/apache/sqoop/client/core/Constants.java
          • client/src/main/resources/client-resource.properties
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #226 (See https://builds.apache.org/job/Sqoop2-hadoop100/226/ ) SQOOP-887 : Sqoop2: Move string constants from FormDisplayer to resource file (Revision daccebac519f65d5d8a62e6be421ff1e382ffa06) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=daccebac519f65d5d8a62e6be421ff1e382ffa06 Files : client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java client/src/main/java/org/apache/sqoop/client/core/Constants.java client/src/main/resources/client-resource.properties
          Show
          Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=daccebac519f65d5d8a62e6be421ff1e382ffa06 Thank you Vasanth! Jarcec
          Hide
          Jarek Jarcec Cecho added a comment -

          Thank you Vasanth kumar RJ for picking this up. Would you mind uploading this patch to the review board?

          Show
          Jarek Jarcec Cecho added a comment - Thank you Vasanth kumar RJ for picking this up. Would you mind uploading this patch to the review board ?

            People

            • Assignee:
              Vasanth kumar RJ
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development