Sqoop
  1. Sqoop
  2. SQOOP-871

Connector-level job-specific prop gives wrong help msg

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: sqoop2-client
    • Labels:
      None

      Description

      In the sqoop2 client I do "show connector --cid=1", and I see 3 forms that all seem to be specific to a particular connector (connector with cid=1 in this case). The forms are:

      1) Connection form (these are apparently the connection-specific props that will be prompted to the user when creating a connection on top of connector cid=1.

      2) Job form (these are apparently job-specific props that will be prompted to the user when creating a job on top of some connection that was in turn created on top of the connector with cid=1)

      The help for the job-specific props shows:
      Help: You must supply the information requested in order to create a connection object.
      ...but should say "job object" instead of "connection object".

      1. SQOOP-871.patch
        0.9 kB
        Will McQueen

        Activity

        Will McQueen created issue -
        Will McQueen made changes -
        Field Original Value New Value
        Attachment SQOOP-871.patch [ 12568532 ]
        Will McQueen made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Will McQueen made changes -
        Description In the sqoop2 client I do "show connector --cid=1", and I see 3 forms that all seem to be specific to a particular connector (connector with cid=1 in this case). The forms are:

        1) Connection form (these are apparently the connection-specific props that will be prompted to the user when creating a connection on top of connector cid=1.

        2) Job form (these are apparently job-specific props that will be prompted to the user when creating a job on top of some connection that was in turn created on top of the connector with cid=1)

        The help for the job-specific props shows:
        Help: You must supply the information requested in order to create a connection object.
        ...but should say "job object" instead of "connection object".
        Hide
        Jarek Jarcec Cecho added a comment -

        It's a simple patch, so I'm giving my +1 here.

        Show
        Jarek Jarcec Cecho added a comment - It's a simple patch, so I'm giving my +1 here.
        Hide
        Jarek Jarcec Cecho added a comment -
        Show
        Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=3ea5145a965a31e8251cad706af06d3cecc92733 Thank you Will for your time! Jarcec
        Jarek Jarcec Cecho made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee Will McQueen [ will@cloudera.com ]
        Fix Version/s 1.99.2 [ 12323640 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Sqoop2-hadoop200 #182 (See https://builds.apache.org/job/Sqoop2-hadoop200/182/)
        SQOOP-871: Connector-level job-specific prop gives wrong help msg (Revision 3ea5145a965a31e8251cad706af06d3cecc92733)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3ea5145a965a31e8251cad706af06d3cecc92733
        Files :

        • connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
        Show
        Hudson added a comment - Integrated in Sqoop2-hadoop200 #182 (See https://builds.apache.org/job/Sqoop2-hadoop200/182/ ) SQOOP-871 : Connector-level job-specific prop gives wrong help msg (Revision 3ea5145a965a31e8251cad706af06d3cecc92733) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3ea5145a965a31e8251cad706af06d3cecc92733 Files : connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
        Hide
        Hudson added a comment -

        Integrated in Sqoop2-hadoop100 #169 (See https://builds.apache.org/job/Sqoop2-hadoop100/169/)
        SQOOP-871: Connector-level job-specific prop gives wrong help msg (Revision 3ea5145a965a31e8251cad706af06d3cecc92733)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3ea5145a965a31e8251cad706af06d3cecc92733
        Files :

        • connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
        Show
        Hudson added a comment - Integrated in Sqoop2-hadoop100 #169 (See https://builds.apache.org/job/Sqoop2-hadoop100/169/ ) SQOOP-871 : Connector-level job-specific prop gives wrong help msg (Revision 3ea5145a965a31e8251cad706af06d3cecc92733) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=3ea5145a965a31e8251cad706af06d3cecc92733 Files : connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties

          People

          • Assignee:
            Will McQueen
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development