Sqoop
  1. Sqoop
  2. SQOOP-858

Sqoop2: Add validation messages on form level

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.99.1
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:
      None

      Description

      We should add also ability to provide error and warning messages to form level instead having those messages connected only to Inputs.

      1. bugSQOOP-858.patch
        19 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-858.patch
        19 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Hide
          Cheolsoo Park added a comment -

          +1. I will commit it after running tests.

          Show
          Cheolsoo Park added a comment - +1. I will commit it after running tests.
          Hide
          Cheolsoo Park added a comment -

          Committed to sqoop2. Thanks Jarcec!

          Show
          Cheolsoo Park added a comment - Committed to sqoop2. Thanks Jarcec!
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #179 (See https://builds.apache.org/job/Sqoop2-hadoop200/179/)
          SQOOP-858: Add validation messages on form level (Revision 727e6f198dc18bc6823155af14821e0c6985d8f4)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=727e6f198dc18bc6823155af14821e0c6985d8f4
          Files :

          • connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
          • client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
          • common/src/test/java/org/apache/sqoop/validation/TestValidation.java
          • common/src/main/java/org/apache/sqoop/validation/Validation.java
          • common/src/main/java/org/apache/sqoop/model/FormUtils.java
          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #179 (See https://builds.apache.org/job/Sqoop2-hadoop200/179/ ) SQOOP-858 : Add validation messages on form level (Revision 727e6f198dc18bc6823155af14821e0c6985d8f4) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=727e6f198dc18bc6823155af14821e0c6985d8f4 Files : connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java common/src/test/java/org/apache/sqoop/validation/TestValidation.java common/src/main/java/org/apache/sqoop/validation/Validation.java common/src/main/java/org/apache/sqoop/model/FormUtils.java connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #166 (See https://builds.apache.org/job/Sqoop2-hadoop100/166/)
          SQOOP-858: Add validation messages on form level (Revision 727e6f198dc18bc6823155af14821e0c6985d8f4)

          Result = SUCCESS
          cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=727e6f198dc18bc6823155af14821e0c6985d8f4
          Files :

          • common/src/test/java/org/apache/sqoop/validation/TestValidation.java
          • client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
          • connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
          • common/src/main/java/org/apache/sqoop/model/FormUtils.java
          • common/src/main/java/org/apache/sqoop/validation/Validation.java
          • connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #166 (See https://builds.apache.org/job/Sqoop2-hadoop100/166/ ) SQOOP-858 : Add validation messages on form level (Revision 727e6f198dc18bc6823155af14821e0c6985d8f4) Result = SUCCESS cheolsoo : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=727e6f198dc18bc6823155af14821e0c6985d8f4 Files : common/src/test/java/org/apache/sqoop/validation/TestValidation.java client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties common/src/main/java/org/apache/sqoop/model/FormUtils.java common/src/main/java/org/apache/sqoop/validation/Validation.java connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcValidator.java

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development