Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-856

PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.3
    • Fix Version/s: 1.4.4
    • Component/s: None
    • Labels:
      None
    • Environment:

      All, Postgresql database

      Description

      The PGBulkloadExportMapper has the following code fragment

      try

      { ... process.waitFor(); ... }

      catch (InterruptedException ie)

      { // interrupted; loop around. continue; }

      We need to log an exception to note the fact that the thread was interrupted ( not sure of any condition except for spurious interrupts)
      Also we need to add a finally block to reset the interrupted condition as mentioned in http://bugs.sun.com/view_bug.do?bug_id=6420270

      1. SQOOP-856.patch
        0.9 kB
        Venkat Ranganathan

        Activity

        Hide
        venkatnrangan Venkat Ranganathan added a comment -

        Attaching a patch for this issue

        Show
        venkatnrangan Venkat Ranganathan added a comment - Attaching a patch for this issue
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        It's a simple change so I'm giving my +1 here.

        Show
        jarcec Jarek Jarcec Cecho added a comment - It's a simple change so I'm giving my +1 here.
        Show
        jarcec Jarek Jarcec Cecho added a comment - The patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=4aa174abee0fc2b8bfb407a4fc5829e22b746413 Thank you Venkat! Jarcec
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop23 #782 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/782/)
        SQOOP-856: PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413
        Files :

        • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #782 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/782/ ) SQOOP-856 : PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413 Files : src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop200 #572 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/572/)
        SQOOP-856: PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413
        Files :

        • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #572 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/572/ ) SQOOP-856 : PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413 Files : src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop20 #575 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/575/)
        SQOOP-856: PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413
        Files :

        • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #575 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/575/ ) SQOOP-856 : PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413 Files : src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6-hadoop100 #583 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/583/)
        SQOOP-856: PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413)

        Result = SUCCESS
        jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413
        Files :

        • src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #583 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/583/ ) SQOOP-856 : PGBulkLoadExportMapper has an infinite waitFor without any logging in the event of Interrupted exceptions (Revision 4aa174abee0fc2b8bfb407a4fc5829e22b746413) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=4aa174abee0fc2b8bfb407a4fc5829e22b746413 Files : src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java

          People

          • Assignee:
            venkatnrangan Venkat Ranganathan
            Reporter:
            venkatnrangan Venkat Ranganathan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development