Sqoop
  1. Sqoop
  2. SQOOP-802

Sqoop2: Convert main "Manager" classes to singletons.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 1.99.2
    • Component/s: None
    • Labels:
      None

      Description

      We currently have several "manager" classes in Sqoop2 - RepositoryManager, ConnectorManager or FrameworkManager. All of them have only static methods. I would like to propose changing them to normal singleton objects, so that we can spoof the instance easily when necessary (for example in tests).

      1. bugSQOOP-802.patch
        42 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Jarek Jarcec Cecho created issue -
          Jarek Jarcec Cecho made changes -
          Field Original Value New Value
          Remote Link This issue links to "Review board (Web Link)" [ 11930 ]
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-802.patch [ 12562294 ]
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 1.99.2 [ 12323640 ]
          Hide
          Bilung Lee added a comment -

          Patch is committed.

          Show
          Bilung Lee added a comment - Patch is committed.
          Bilung Lee made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop200 #46 (See https://builds.apache.org/job/Sqoop2-hadoop200/46/)
          SQOOP-802 Convert main "Manager" classes to singletons (Revision 46b50e3f68ef60939e271368d14a2119bcc82574)

          Result = UNSTABLE
          blee : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=46b50e3f68ef60939e271368d14a2119bcc82574
          Files :

          • server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
          • core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
          • server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
          • core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java
          • server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
          • core/src/test/java/org/apache/sqoop/core/TestConfiguration.java
          • core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
          • core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
          • server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
          • core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
          • server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
          • server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop200 #46 (See https://builds.apache.org/job/Sqoop2-hadoop200/46/ ) SQOOP-802 Convert main "Manager" classes to singletons (Revision 46b50e3f68ef60939e271368d14a2119bcc82574) Result = UNSTABLE blee : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=46b50e3f68ef60939e271368d14a2119bcc82574 Files : server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java server/src/main/java/org/apache/sqoop/server/ServerInitializer.java core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java core/src/test/java/org/apache/sqoop/core/TestConfiguration.java core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop2-hadoop100 #45 (See https://builds.apache.org/job/Sqoop2-hadoop100/45/)
          SQOOP-802 Convert main "Manager" classes to singletons (Revision 46b50e3f68ef60939e271368d14a2119bcc82574)

          Result = SUCCESS
          blee : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=46b50e3f68ef60939e271368d14a2119bcc82574
          Files :

          • core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
          • server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
          • core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java
          • core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java
          • server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java
          • core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java
          • server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
          • server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
          • server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
          • core/src/test/java/org/apache/sqoop/core/TestConfiguration.java
          • server/src/main/java/org/apache/sqoop/server/ServerInitializer.java
          • core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
          • core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
          Show
          Hudson added a comment - Integrated in Sqoop2-hadoop100 #45 (See https://builds.apache.org/job/Sqoop2-hadoop100/45/ ) SQOOP-802 Convert main "Manager" classes to singletons (Revision 46b50e3f68ef60939e271368d14a2119bcc82574) Result = SUCCESS blee : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=46b50e3f68ef60939e271368d14a2119bcc82574 Files : core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryProvider.java core/src/test/java/org/apache/sqoop/repository/TestRepositoryManager.java server/src/main/java/org/apache/sqoop/handler/FrameworkRequestHandler.java core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java core/src/test/java/org/apache/sqoop/core/TestConfiguration.java server/src/main/java/org/apache/sqoop/server/ServerInitializer.java core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java
          Hide
          Jarek Jarcec Cecho added a comment -

          The UNSTABLE for hadoop200 seems as an temporal glitch. It's passing locally for me and rerun also cleared the issue on jenkins.

          Show
          Jarek Jarcec Cecho added a comment - The UNSTABLE for hadoop200 seems as an temporal glitch. It's passing locally for me and rerun also cleared the issue on jenkins.
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6m 13s 1 Jarek Jarcec Cecho 23/Dec/12 22:54
          Patch Available Patch Available Resolved Resolved
          2d 23h 34m 1 Bilung Lee 26/Dec/12 22:29

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development