Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 1.99.1
    • Component/s: None
    • Labels:
      None

      Description

      I would like to propose two improvements to current building (dist module):

      • Build both source and binary artifacts at the same time. As as I understand a lot of other projects are doing that as well and it seems more friendly than creating one package at the time.
      • Encode hadoop profile into binary artifact name. I believe that we should encode for which Hadoop version is given binary artifact suitable. I know that only two jars are actually "hadoop specific" whereas the others will work across all hadoop distributions, but I believe that it will be more user friendly.
      1. bugSQOOP-722.patch
        6 kB
        Jarek Jarcec Cecho
      2. bugSQOOP-722.patch
        12 kB
        Jarek Jarcec Cecho

        Issue Links

          Activity

          Jarek Jarcec Cecho created issue -
          Jarek Jarcec Cecho made changes -
          Field Original Value New Value
          Remote Link This issue links to "Review board (Web Link)" [ 11511 ]
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-722.patch [ 12554703 ]
          Jarek Jarcec Cecho made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Abhijeet Gaikwad added a comment -

          Second suggestion is a go ahead.
          For the first, I feel source and binary packages should be different. When a user wants to pack only source, binary is an unnecessary attachment. Similarly, when a user or more specifically RM creates a binary package, source will be packed per hadoop profile - which doesn't just seem right, provided source is hadoop profile independent. Let me know your views. If my understanding is correct, its a -1.

          Show
          Abhijeet Gaikwad added a comment - Second suggestion is a go ahead. For the first, I feel source and binary packages should be different. When a user wants to pack only source, binary is an unnecessary attachment. Similarly, when a user or more specifically RM creates a binary package, source will be packed per hadoop profile - which doesn't just seem right, provided source is hadoop profile independent. Let me know your views. If my understanding is correct, its a -1.
          Hide
          Jarek Jarcec Cecho added a comment -

          Hi Abhijeet,
          thank you very much for your feedback, I appreciate your time.

          Regarding your concern on first suggestion. I believe that we quite did not understand each other, so let me describe the suggestion little bit more. Right now user had to call maven twice to build source and binary artifacts. With this patch he need to call maven only once. However even thought we still build two separate artifacts. This suggestion is only about building both artifacts during single maven call. Consider following list with created artifacts:

          • mvn package -Dhadoop.profile=200
            • sqoop-2.0.0-SNAPSHOT.tar.gz (source)
            • sqoop-2.0.0-SNAPSHOT-bin-hadoop200.tar.gz (binary)
          • mvn package -Dhadoop.profile=100
            • sqoop-2.0.0-SNAPSHOT.tar.gz (source)
            • sqoop-2.0.0-SNAPSHOT-bin-hadoop100.tar.gz (binary)

          The source artifacts are exactly the same in both profiles as they are independent on Hadoop version. They just happen to be created each time. Does this help clear your concern?

          Show
          Jarek Jarcec Cecho added a comment - Hi Abhijeet, thank you very much for your feedback, I appreciate your time. Regarding your concern on first suggestion. I believe that we quite did not understand each other, so let me describe the suggestion little bit more. Right now user had to call maven twice to build source and binary artifacts. With this patch he need to call maven only once. However even thought we still build two separate artifacts. This suggestion is only about building both artifacts during single maven call. Consider following list with created artifacts: mvn package -Dhadoop.profile=200 sqoop-2.0.0-SNAPSHOT.tar.gz (source) sqoop-2.0.0-SNAPSHOT-bin-hadoop200.tar.gz (binary) mvn package -Dhadoop.profile=100 sqoop-2.0.0-SNAPSHOT.tar.gz (source) sqoop-2.0.0-SNAPSHOT-bin-hadoop100.tar.gz (binary) The source artifacts are exactly the same in both profiles as they are independent on Hadoop version. They just happen to be created each time. Does this help clear your concern?
          Hide
          Abhijeet Gaikwad added a comment -

          Thanks for clarifying Jarcec.
          On your first suggestion, I feel packaging source and binaries are two independent tasks and should not be merged into one.
          -1.

          Thanks.

          Show
          Abhijeet Gaikwad added a comment - Thanks for clarifying Jarcec. On your first suggestion, I feel packaging source and binaries are two independent tasks and should not be merged into one. -1. Thanks.
          Jarek Jarcec Cecho made changes -
          Attachment bugSQOOP-722.patch [ 12555522 ]
          Jarek Jarcec Cecho made changes -
          Link This issue blocks SQOOP-703 [ SQOOP-703 ]
          Hide
          Jarek Jarcec Cecho added a comment -

          I've removed first proposed suggestion from the patch per Abhijeet's -1.

          Show
          Jarek Jarcec Cecho added a comment - I've removed first proposed suggestion from the patch per Abhijeet's -1.
          Hide
          Abhijeet Gaikwad added a comment -

          Thanks Jarcec.
          The patch looks good to me.

          Show
          Abhijeet Gaikwad added a comment - Thanks Jarcec. The patch looks good to me.
          Hide
          Bilung Lee added a comment -

          Thanks Jarcec's contribution and Abhijeet's review. The patch is committed now.

          Show
          Bilung Lee added a comment - Thanks Jarcec's contribution and Abhijeet's review. The patch is committed now.
          Bilung Lee made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Jarek Jarcec Cecho made changes -
          Fix Version/s 1.99.1 [ 12323641 ]
          Fix Version/s 2.0.0 [ 12319272 ]

            People

            • Assignee:
              Jarek Jarcec Cecho
              Reporter:
              Jarek Jarcec Cecho
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development