Sqoop
  1. Sqoop
  2. SQOOP-657

ant checkstyle results in errors

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.3
    • Component/s: None
    • Labels:

      Description

      Error details:
      File /home/abhijeet/apache-sqoop/git-sqoop/sqoop/src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java

      Line:Description
      198:Line is longer than 80 characters.
      201:Line is longer than 80 characters.

      1. SQOOP-657.patch
        1 kB
        Alexander Alten-Lorenz

        Issue Links

          Activity

          Hide
          Alexander Alten-Lorenz added a comment -

          ant test

          checkfailure:
          
          test:
          
          BUILD SUCCESSFUL
          Total time: 12 minutes 11 seconds
          

          Can't reproduce, please attach logs.

          Show
          Alexander Alten-Lorenz added a comment - ant test checkfailure: test: BUILD SUCCESSFUL Total time: 12 minutes 11 seconds Can't reproduce, please attach logs.
          Hide
          Abhijeet Gaikwad added a comment -

          You should run "ant checkstyle".

          Locating checkstyle errors is tricky. The ant target may be successful, but an html file is generated in $SQOOP_HOME directory that lists the error details.

          Let me know.

          Show
          Abhijeet Gaikwad added a comment - You should run "ant checkstyle". Locating checkstyle errors is tricky. The ant target may be successful, but an html file is generated in $SQOOP_HOME directory that lists the error details. Let me know.
          Hide
          Jarek Jarcec Cecho added a comment -

          As Abhijeet has mentioned ant's goal checkstyle is just to create checkstyle report. That's why you will see "build successful" even when running "ant checkstyle". One needs to open the generated report manually and check that there are not outstanding code style violations.

          Jarcec

          Show
          Jarek Jarcec Cecho added a comment - As Abhijeet has mentioned ant's goal checkstyle is just to create checkstyle report. That's why you will see "build successful" even when running "ant checkstyle". One needs to open the generated report manually and check that there are not outstanding code style violations. Jarcec
          Show
          Alexander Alten-Lorenz added a comment - https://reviews.apache.org/r/8010/
          Hide
          Jarek Jarcec Cecho added a comment -
          Show
          Jarek Jarcec Cecho added a comment - Patch is in: https://git-wip-us.apache.org/repos/asf?p=sqoop.git;a=commit;h=95098af0e0c62826f469ea6ed1b7420d2cf55abb Thank you Alex for your contribution! Jarcec
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop100 #280 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/280/)
          SQOOP-657: ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb
          Files :

          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop100 #280 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop100/280/ ) SQOOP-657 : ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop200 #286 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/286/)
          SQOOP-657: ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb
          Files :

          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop200 #286 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop200/286/ ) SQOOP-657 : ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop20 #286 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/286/)
          SQOOP-657: ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb
          Files :

          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop20 #286 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop20/286/ ) SQOOP-657 : ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Hide
          Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6-hadoop23 #442 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/442/)
          SQOOP-657: ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb)

          Result = SUCCESS
          jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb
          Files :

          • src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
          Show
          Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6-hadoop23 #442 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6-hadoop23/442/ ) SQOOP-657 : ant checkstyle results in errors (Revision 95098af0e0c62826f469ea6ed1b7420d2cf55abb) Result = SUCCESS jarcec : https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=95098af0e0c62826f469ea6ed1b7420d2cf55abb Files : src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java

            People

            • Assignee:
              Alexander Alten-Lorenz
              Reporter:
              Abhijeet Gaikwad
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development