Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-522

Move printing error "ERROR orm.CompilationManager: Could not rename" to DEBUG

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:
      None

      Description

      We're currently creating generated class in temporary directory and then moving to final directory. However in case that the file is already there (for example from previous run), we print out ogly exception stack trace. I would like to change this error message from ERROR to DEBUG as this error message is being ignored anyway.

      Example of the stack trace:

      12/04/09 17:28:38 ERROR orm.CompilationManager: Could not rename /tmp/location to /final/location
      java.io.IOException: Destination '/final/location' already exists
      at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:1811)
      at org.apache.sqoop.orm.CompilationManager.compile(CompilationManager.java:227)
      at org.apache.sqoop.tool.CodeGenTool.generateORM(CodeGenTool.java:83)

      1. SQOOP-522.patch
        0.5 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #126 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/126/)
        SQOOP-522. Move printing error "ERROR orm.CompilationManager: Could not rename" to DEBUG
        (Jarek Jarcec Cecho via Kathleen Ting) (Revision 1365320)

        Result = SUCCESS
        kathleen :
        Files :

        • /sqoop/trunk/src/java/org/apache/sqoop/orm/CompilationManager.java
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #126 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/126/ ) SQOOP-522 . Move printing error "ERROR orm.CompilationManager: Could not rename" to DEBUG (Jarek Jarcec Cecho via Kathleen Ting) (Revision 1365320) Result = SUCCESS kathleen : Files : /sqoop/trunk/src/java/org/apache/sqoop/orm/CompilationManager.java
        Hide
        kathleen Kathleen Ting added a comment -

        Patch committed. Thanks Jarcec.

        Show
        kathleen Kathleen Ting added a comment - Patch committed. Thanks Jarcec.
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        I'm bypassing review board as this is very simple change.

        Show
        jarcec Jarek Jarcec Cecho added a comment - I'm bypassing review board as this is very simple change.

          People

          • Assignee:
            jarcec Jarek Jarcec Cecho
            Reporter:
            jarcec Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development