Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-484

Update troubleshooting guide section about MySQL and TINYINT(1) columns

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.1-incubating
    • Fix Version/s: 1.4.2
    • Component/s: docs
    • Labels:
      None

      Description

      This issue is continuation of JIRA ticket SQOOP-463.

      I've investigated MySQL JDBC connector behavior in case of columns defined as TINYINT(1). By default MySQL JDBC connector is converting TINYINT(1) into java.sql.Types.BIT, which can be very easily turned off by specifying tinyInt1isBit=false in JDBC path. For example jdbc:mysql://localhost/test?tinyInt1isBit=false. I would suggest to update troubleshooting guide by suggesting users to set this property rather than overriding default sqoop type mapping.

      1. SQOOP-484.patch
        2 kB
        Jarek Jarcec Cecho
      2. SQOOP-484.patch
        2 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5065/
        -----------------------------------------------------------

        Review request for Sqoop and Kathleen Ting.

        Summary
        -------

        I've updated corresponding section in Troubleshooting guide.

        This addresses bug SQOOP-484.
        https://issues.apache.org/jira/browse/SQOOP-484

        Diffs


        /src/docs/user/troubleshooting.txt 1335407

        Diff: https://reviews.apache.org/r/5065/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/ ----------------------------------------------------------- Review request for Sqoop and Kathleen Ting. Summary ------- I've updated corresponding section in Troubleshooting guide. This addresses bug SQOOP-484 . https://issues.apache.org/jira/browse/SQOOP-484 Diffs /src/docs/user/troubleshooting.txt 1335407 Diff: https://reviews.apache.org/r/5065/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5065/#review7751
        -----------------------------------------------------------

        Jarcec - good work. Some feedback.
        1.) "This is because by default MySQL" needs a 'the', i.e. "This is because by default the MySQL"
        2.) How about "A more clean solution" instead of "Most cleaner solution"?
        3.) How about expanding on "Another solution would be to use sqoop ability to override default mapping." - e.g. Another solution would be to explicitly override the column mapping for the datatype TINYINT(1) column. For example, if the column name is foo, then pass the following option to Sqoop during import: --map-column-hive foo=tinyint. In the case of non-Hive imports to HDFS, use --map-column-java foo=integer.

        • Kathleen

        On 2012-05-08 11:21:33, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5065/

        -----------------------------------------------------------

        (Updated 2012-05-08 11:21:33)

        Review request for Sqoop and Kathleen Ting.

        Summary

        -------

        I've updated corresponding section in Troubleshooting guide.

        This addresses bug SQOOP-484.

        https://issues.apache.org/jira/browse/SQOOP-484

        Diffs

        -----

        /src/docs/user/troubleshooting.txt 1335407

        Diff: https://reviews.apache.org/r/5065/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/#review7751 ----------------------------------------------------------- Jarcec - good work. Some feedback. 1.) "This is because by default MySQL" needs a 'the', i.e. "This is because by default the MySQL" 2.) How about "A more clean solution" instead of "Most cleaner solution"? 3.) How about expanding on "Another solution would be to use sqoop ability to override default mapping." - e.g. Another solution would be to explicitly override the column mapping for the datatype TINYINT(1) column. For example, if the column name is foo, then pass the following option to Sqoop during import: --map-column-hive foo=tinyint. In the case of non-Hive imports to HDFS, use --map-column-java foo=integer. Kathleen On 2012-05-08 11:21:33, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/ ----------------------------------------------------------- (Updated 2012-05-08 11:21:33) Review request for Sqoop and Kathleen Ting. Summary ------- I've updated corresponding section in Troubleshooting guide. This addresses bug SQOOP-484 . https://issues.apache.org/jira/browse/SQOOP-484 Diffs ----- /src/docs/user/troubleshooting.txt 1335407 Diff: https://reviews.apache.org/r/5065/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5065/
        -----------------------------------------------------------

        (Updated 2012-05-12 14:07:22.638820)

        Review request for Sqoop and Kathleen Ting.

        Changes
        -------

        Hi Kate,
        thank you very much for your feedback. I appreciate your help with improving my English

        I've incorporated all your suggestions and uploaded new patch.

        Jarcec

        Summary
        -------

        I've updated corresponding section in Troubleshooting guide.

        This addresses bug SQOOP-484.
        https://issues.apache.org/jira/browse/SQOOP-484

        Diffs (updated)


        /src/docs/user/troubleshooting.txt 1336267

        Diff: https://reviews.apache.org/r/5065/diff

        Testing
        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/ ----------------------------------------------------------- (Updated 2012-05-12 14:07:22.638820) Review request for Sqoop and Kathleen Ting. Changes ------- Hi Kate, thank you very much for your feedback. I appreciate your help with improving my English I've incorporated all your suggestions and uploaded new patch. Jarcec Summary ------- I've updated corresponding section in Troubleshooting guide. This addresses bug SQOOP-484 . https://issues.apache.org/jira/browse/SQOOP-484 Diffs (updated) /src/docs/user/troubleshooting.txt 1336267 Diff: https://reviews.apache.org/r/5065/diff Testing ------- Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5065/#review7833
        -----------------------------------------------------------

        Ship it!

        Looks good. Thanks Jarcec.

        • Kathleen

        On 2012-05-12 14:07:22, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5065/

        -----------------------------------------------------------

        (Updated 2012-05-12 14:07:22)

        Review request for Sqoop and Kathleen Ting.

        Summary

        -------

        I've updated corresponding section in Troubleshooting guide.

        This addresses bug SQOOP-484.

        https://issues.apache.org/jira/browse/SQOOP-484

        Diffs

        -----

        /src/docs/user/troubleshooting.txt 1336267

        Diff: https://reviews.apache.org/r/5065/diff

        Testing

        -------

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/#review7833 ----------------------------------------------------------- Ship it! Looks good. Thanks Jarcec. Kathleen On 2012-05-12 14:07:22, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5065/ ----------------------------------------------------------- (Updated 2012-05-12 14:07:22) Review request for Sqoop and Kathleen Ting. Summary ------- I've updated corresponding section in Troubleshooting guide. This addresses bug SQOOP-484 . https://issues.apache.org/jira/browse/SQOOP-484 Diffs ----- /src/docs/user/troubleshooting.txt 1336267 Diff: https://reviews.apache.org/r/5065/diff Testing ------- Thanks, Jarek
        Hide
        kathleen Kathleen Ting added a comment -

        Patch committed. Thanks Jarcec!

        Show
        kathleen Kathleen Ting added a comment - Patch committed. Thanks Jarcec!
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #113 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/113/)
        SQOOP-484. Update troubleshooting guide section about MySQL and TINYINT(1) columns
        (Jarek Jarcec Cecho via Kathleen Ting) (Revision 1338034)

        Result = SUCCESS
        kathleen :
        Files :

        • /sqoop/trunk/src/docs/user/troubleshooting.txt
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #113 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/113/ ) SQOOP-484 . Update troubleshooting guide section about MySQL and TINYINT(1) columns (Jarek Jarcec Cecho via Kathleen Ting) (Revision 1338034) Result = SUCCESS kathleen : Files : /sqoop/trunk/src/docs/user/troubleshooting.txt
        Hide
        tispratik Pratik Khadloya added a comment -

        Thanks for updating the docs. It is very helpful information.

        Show
        tispratik Pratik Khadloya added a comment - Thanks for updating the docs. It is very helpful information.

          People

          • Assignee:
            jarcec Jarek Jarcec Cecho
            Reporter:
            jarcec Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development