Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-459

Remove redundant steps in compatibility tests: verifyReadback() method

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:

      Description

      Several tests including ManagerCompatTest do the following:

      1) Tests insert data
      2) Compare output from the db against inserted values
      3) Run Sqoop import jobs
      4) Compare output read from seq files against inserted values

      Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

      Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.

      1. SQOOP-459.patch
        32 kB
        Cheolsoo Park

        Issue Links

          Activity

          Hide
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4266/
          -----------------------------------------------------------

          Review request for Sqoop and Bilung Lee.

          Summary
          -------

          Several tests including ManagerCompatTest do the following:

          1) Tests insert data
          2) Compare output from the db against inserted values
          3) Run Sqoop import jobs
          4) Compare output read from seq files against inserted values

          Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

          Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.

          This addresses bug SQOOP-459.
          https://issues.apache.org/jira/browse/SQOOP-459

          Diffs


          ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
          ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
          ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
          ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
          ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
          ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661

          Diff: https://reviews.apache.org/r/4266/diff

          Testing
          -------

          Thanks,

          Cheolsoo

          Show
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4266/ ----------------------------------------------------------- Review request for Sqoop and Bilung Lee. Summary ------- Several tests including ManagerCompatTest do the following: 1) Tests insert data 2) Compare output from the db against inserted values 3) Run Sqoop import jobs 4) Compare output read from seq files against inserted values Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver. Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them. This addresses bug SQOOP-459 . https://issues.apache.org/jira/browse/SQOOP-459 Diffs ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661 ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661 ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661 ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661 Diff: https://reviews.apache.org/r/4266/diff Testing ------- Thanks, Cheolsoo
          Hide
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4266/
          -----------------------------------------------------------

          (Updated 2012-03-09 19:38:14.027866)

          Review request for Sqoop and Bilung Lee.

          Summary
          -------

          Several tests including ManagerCompatTest do the following:

          1) Tests insert data
          2) Compare output from the db against inserted values
          3) Run Sqoop import jobs
          4) Compare output read from seq files against inserted values

          Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

          Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.

          This addresses bug SQOOP-459.
          https://issues.apache.org/jira/browse/SQOOP-459

          Diffs


          ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661
          ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661
          ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661
          ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661
          ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661
          ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661

          Diff: https://reviews.apache.org/r/4266/diff

          Testing (updated)
          -------

          Ran
          ant test
          ant test -Dthirdparty
          ant checkstyle

          Thanks,

          Cheolsoo

          Show
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4266/ ----------------------------------------------------------- (Updated 2012-03-09 19:38:14.027866) Review request for Sqoop and Bilung Lee. Summary ------- Several tests including ManagerCompatTest do the following: 1) Tests insert data 2) Compare output from the db against inserted values 3) Run Sqoop import jobs 4) Compare output read from seq files against inserted values Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver. Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them. This addresses bug SQOOP-459 . https://issues.apache.org/jira/browse/SQOOP-459 Diffs ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661 ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661 ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661 ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661 Diff: https://reviews.apache.org/r/4266/diff Testing (updated) ------- Ran ant test ant test -Dthirdparty ant checkstyle Thanks, Cheolsoo
          Hide
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4266/#review5800
          -----------------------------------------------------------

          Ship it!

          Thanks for the patch!

          • Bilung

          On 2012-03-09 19:38:14, Cheolsoo Park wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4266/

          -----------------------------------------------------------

          (Updated 2012-03-09 19:38:14)

          Review request for Sqoop and Bilung Lee.

          Summary

          -------

          Several tests including ManagerCompatTest do the following:

          1) Tests insert data

          2) Compare output from the db against inserted values

          3) Run Sqoop import jobs

          4) Compare output read from seq files against inserted values

          Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver.

          Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them.

          This addresses bug SQOOP-459.

          https://issues.apache.org/jira/browse/SQOOP-459

          Diffs

          -----

          ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661

          ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661

          ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661

          ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661

          ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661

          ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661

          Diff: https://reviews.apache.org/r/4266/diff

          Testing

          -------

          Ran

          ant test

          ant test -Dthirdparty

          ant checkstyle

          Thanks,

          Cheolsoo

          Show
          jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4266/#review5800 ----------------------------------------------------------- Ship it! Thanks for the patch! Bilung On 2012-03-09 19:38:14, Cheolsoo Park wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4266/ ----------------------------------------------------------- (Updated 2012-03-09 19:38:14) Review request for Sqoop and Bilung Lee. Summary ------- Several tests including ManagerCompatTest do the following: 1) Tests insert data 2) Compare output from the db against inserted values 3) Run Sqoop import jobs 4) Compare output read from seq files against inserted values Tthe step 2 is redundant since the step 4 also verifies output. In addition, these tests are fragile since output formats vary depending on versions/vendors of the DB/JDBC driver. Since there is little value to gain from these tests while they cause compatibility problems, it would be better to remove them. This addresses bug SQOOP-459 . https://issues.apache.org/jira/browse/SQOOP-459 Diffs ----- ./src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 1298661 ./src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java 1298661 ./src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/manager/OracleCompatTest.java 1298661 ./src/test/com/cloudera/sqoop/TestMultiCols.java 1298661 ./src/test/com/cloudera/sqoop/TestColumnTypes.java 1298661 Diff: https://reviews.apache.org/r/4266/diff Testing ------- Ran ant test ant test -Dthirdparty ant checkstyle Thanks, Cheolsoo
          Hide
          bleeapache Bilung Lee added a comment -

          Patch committed. Thanks, Cheolsoo!

          Show
          bleeapache Bilung Lee added a comment - Patch committed. Thanks, Cheolsoo!
          Hide
          hudson Hudson added a comment -

          Integrated in Sqoop-ant-jdk-1.6 #95 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/95/)
          SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method (Revision 1299056)

          Result = SUCCESS
          blee : http://svn.apache.org/viewvc/?view=rev&rev=1299056
          Files :

          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestColumnTypes.java
          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java
          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java
          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java
          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java
          • /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java
          Show
          hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #95 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/95/ ) SQOOP-459 Remove redundant steps in compatibility tests: verifyReadback() method (Revision 1299056) Result = SUCCESS blee : http://svn.apache.org/viewvc/?view=rev&rev=1299056 Files : /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestColumnTypes.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/TestMultiCols.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/manager/OracleCompatTest.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java /incubator/sqoop/trunk/src/test/com/cloudera/sqoop/testutil/ManagerCompatTestCase.java

            People

            • Assignee:
              cheolsoo Cheolsoo Park
              Reporter:
              cheolsoo Cheolsoo Park
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development