Uploaded image for project: 'Sqoop'
  1. Sqoop
  2. SQOOP-439

Released artifacts should embrace unwritten naming policy

    Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.2
    • Component/s: None
    • Labels:
      None

      Description

      We should make source artifact default by removing "-src" postfix from it's name to have similar naming policies as other hadoop related projects.

      More info can be found on following mail thread http://markmail.org/message/krec2kionhxbrmhw

      1. SQOOP-439.patch
        6 kB
        Jarek Jarcec Cecho
      2. SQOOP-439.patch
        6 kB
        Jarek Jarcec Cecho

        Activity

        Hide
        aprabhakar Arvind Prabhakar added a comment -

        @Jarcec - thanks for filing this. Perhaps the resolution of this issue is to update our How To Release page on the wiki and call out the exact details of how the artifacts should be named. I have the following suggestion:

        • Source artifact is named by the project/version as usual: sqoop-1.4.1-incubating.tar.gz
        • Binary artifacts are named by project/version with a ".bin" suffix and other details like hadoop version etc. For example: sqoop-1.4.1-incubating.bin__hadoop-0.20.tar.gz

        What do you think?

        Show
        aprabhakar Arvind Prabhakar added a comment - @Jarcec - thanks for filing this. Perhaps the resolution of this issue is to update our How To Release page on the wiki and call out the exact details of how the artifacts should be named. I have the following suggestion: Source artifact is named by the project/version as usual: sqoop-1.4.1-incubating.tar.gz Binary artifacts are named by project/version with a ".bin" suffix and other details like hadoop version etc. For example: sqoop-1.4.1-incubating.bin__hadoop-0.20.tar.gz What do you think?
        Hide
        jarcec Jarek Jarcec Cecho added a comment -

        Thank you for your feedback Arvind. I agree with you on suggested naming convention.

        I would like to see if ant can be easily modified to generate properly named artifacts instead of changing only the wiki. I would like to have as much as possible done by
        ant so that Release Manager do not have to deal with everything manually.

        I know that we're going to abandon ant in sqoop 2 and that's why I'm saying "easily modified"

        Jarcec

        Show
        jarcec Jarek Jarcec Cecho added a comment - Thank you for your feedback Arvind. I agree with you on suggested naming convention. I would like to see if ant can be easily modified to generate properly named artifacts instead of changing only the wiki. I would like to have as much as possible done by ant so that Release Manager do not have to deal with everything manually. I know that we're going to abandon ant in sqoop 2 and that's why I'm saying "easily modified" Jarcec
        Hide
        aprabhakar Arvind Prabhakar added a comment -

        +1 for that Jarcec. Automating this in the build will reduce the burden on RM going forward and worth spending the time to do that.

        Show
        aprabhakar Arvind Prabhakar added a comment - +1 for that Jarcec. Automating this in the build will reduce the burden on RM going forward and worth spending the time to do that.
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3949/
        -----------------------------------------------------------

        Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

        Summary
        -------

        I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

        I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

        I'll update wiki page "How to Release" in case that this patch will be accepted.

        This addresses bug SQOOP-439.
        https://issues.apache.org/jira/browse/SQOOP-439

        Diffs


        /build.xml 1245157

        Diff: https://reviews.apache.org/r/3949/diff

        Testing
        -------

        ant srctar
        ant tar

        • Inside generated artifacts both "ant test" and "ant releaseaudit"

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/ ----------------------------------------------------------- Review request for Sqoop, Arvind Prabhakar and Bilung Lee. Summary ------- I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases. I've tried to use AntCall ( http://ant.apache.org/manual/Tasks/antcall.html ) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time. I'll update wiki page "How to Release" in case that this patch will be accepted. This addresses bug SQOOP-439 . https://issues.apache.org/jira/browse/SQOOP-439 Diffs /build.xml 1245157 Diff: https://reviews.apache.org/r/3949/diff Testing ------- ant srctar ant tar Inside generated artifacts both "ant test" and "ant releaseaudit" Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3949/#review5257
        -----------------------------------------------------------

        Ship it!

        Look good overall. Just one minor suggestion below.

        /build.xml
        <https://reviews.apache.org/r/3949/#comment11474>

        value="$

        {artifact.name}

        "

        • Bilung

        On 2012-02-18 16:15:07, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3949/

        -----------------------------------------------------------

        (Updated 2012-02-18 16:15:07)

        Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

        Summary

        -------

        I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

        I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

        I'll update wiki page "How to Release" in case that this patch will be accepted.

        This addresses bug SQOOP-439.

        https://issues.apache.org/jira/browse/SQOOP-439

        Diffs

        -----

        /build.xml 1245157

        Diff: https://reviews.apache.org/r/3949/diff

        Testing

        -------

        ant srctar

        ant tar

        - Inside generated artifacts both "ant test" and "ant releaseaudit"

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/#review5257 ----------------------------------------------------------- Ship it! Look good overall. Just one minor suggestion below. /build.xml < https://reviews.apache.org/r/3949/#comment11474 > value="$ {artifact.name} " Bilung On 2012-02-18 16:15:07, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/ ----------------------------------------------------------- (Updated 2012-02-18 16:15:07) Review request for Sqoop, Arvind Prabhakar and Bilung Lee. Summary ------- I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases. I've tried to use AntCall ( http://ant.apache.org/manual/Tasks/antcall.html ) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time. I'll update wiki page "How to Release" in case that this patch will be accepted. This addresses bug SQOOP-439 . https://issues.apache.org/jira/browse/SQOOP-439 Diffs ----- /build.xml 1245157 Diff: https://reviews.apache.org/r/3949/diff Testing ------- ant srctar ant tar - Inside generated artifacts both "ant test" and "ant releaseaudit" Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3949/
        -----------------------------------------------------------

        (Updated 2012-02-22 08:01:10.675913)

        Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

        Changes
        -------

        Applied Bilung's suggestion.

        Summary
        -------

        I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

        I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

        I'll update wiki page "How to Release" in case that this patch will be accepted.

        This addresses bug SQOOP-439.
        https://issues.apache.org/jira/browse/SQOOP-439

        Diffs (updated)


        /build.xml 1292137

        Diff: https://reviews.apache.org/r/3949/diff

        Testing
        -------

        ant srctar
        ant tar

        • Inside generated artifacts both "ant test" and "ant releaseaudit"

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/ ----------------------------------------------------------- (Updated 2012-02-22 08:01:10.675913) Review request for Sqoop, Arvind Prabhakar and Bilung Lee. Changes ------- Applied Bilung's suggestion. Summary ------- I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases. I've tried to use AntCall ( http://ant.apache.org/manual/Tasks/antcall.html ) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time. I'll update wiki page "How to Release" in case that this patch will be accepted. This addresses bug SQOOP-439 . https://issues.apache.org/jira/browse/SQOOP-439 Diffs (updated) /build.xml 1292137 Diff: https://reviews.apache.org/r/3949/diff Testing ------- ant srctar ant tar Inside generated artifacts both "ant test" and "ant releaseaudit" Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3949/#review5289
        -----------------------------------------------------------

        Ship it!

        +1

        • Bilung

        On 2012-02-22 08:01:10, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3949/

        -----------------------------------------------------------

        (Updated 2012-02-22 08:01:10)

        Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

        Summary

        -------

        I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

        I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

        I'll update wiki page "How to Release" in case that this patch will be accepted.

        This addresses bug SQOOP-439.

        https://issues.apache.org/jira/browse/SQOOP-439

        Diffs

        -----

        /build.xml 1292137

        Diff: https://reviews.apache.org/r/3949/diff

        Testing

        -------

        ant srctar

        ant tar

        - Inside generated artifacts both "ant test" and "ant releaseaudit"

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/#review5289 ----------------------------------------------------------- Ship it! +1 Bilung On 2012-02-22 08:01:10, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/ ----------------------------------------------------------- (Updated 2012-02-22 08:01:10) Review request for Sqoop, Arvind Prabhakar and Bilung Lee. Summary ------- I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases. I've tried to use AntCall ( http://ant.apache.org/manual/Tasks/antcall.html ) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time. I'll update wiki page "How to Release" in case that this patch will be accepted. This addresses bug SQOOP-439 . https://issues.apache.org/jira/browse/SQOOP-439 Diffs ----- /build.xml 1292137 Diff: https://reviews.apache.org/r/3949/diff Testing ------- ant srctar ant tar - Inside generated artifacts both "ant test" and "ant releaseaudit" Thanks, Jarek
        Hide
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment -

        On 2012-02-22 19:41:46, Bilung Lee wrote:

        > +1

        Thank you very much for your review sir. I've already uploaded updated patch to JIRA, so please feel free to commit it in.

        • Jarek

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3949/#review5289
        -----------------------------------------------------------

        On 2012-02-22 08:01:10, Jarek Cecho wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3949/

        -----------------------------------------------------------

        (Updated 2012-02-22 08:01:10)

        Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

        Summary

        -------

        I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

        I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

        I'll update wiki page "How to Release" in case that this patch will be accepted.

        This addresses bug SQOOP-439.

        https://issues.apache.org/jira/browse/SQOOP-439

        Diffs

        -----

        /build.xml 1292137

        Diff: https://reviews.apache.org/r/3949/diff

        Testing

        -------

        ant srctar

        ant tar

        - Inside generated artifacts both "ant test" and "ant releaseaudit"

        Thanks,

        Jarek

        Show
        jiraposter@reviews.apache.org jiraposter@reviews.apache.org added a comment - On 2012-02-22 19:41:46, Bilung Lee wrote: > +1 Thank you very much for your review sir. I've already uploaded updated patch to JIRA, so please feel free to commit it in. Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/#review5289 ----------------------------------------------------------- On 2012-02-22 08:01:10, Jarek Cecho wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3949/ ----------------------------------------------------------- (Updated 2012-02-22 08:01:10) Review request for Sqoop, Arvind Prabhakar and Bilung Lee. Summary ------- I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases. I've tried to use AntCall ( http://ant.apache.org/manual/Tasks/antcall.html ) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time. I'll update wiki page "How to Release" in case that this patch will be accepted. This addresses bug SQOOP-439 . https://issues.apache.org/jira/browse/SQOOP-439 Diffs ----- /build.xml 1292137 Diff: https://reviews.apache.org/r/3949/diff Testing ------- ant srctar ant tar - Inside generated artifacts both "ant test" and "ant releaseaudit" Thanks, Jarek
        Hide
        hudson Hudson added a comment -

        Integrated in Sqoop-ant-jdk-1.6 #86 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/86/)
        SQOOP-439: Released artifacts should embrace unwritten naming policy (Revision 1292486)

        Result = SUCCESS
        blee : http://svn.apache.org/viewvc/?view=rev&rev=1292486
        Files :

        • /incubator/sqoop/trunk/build.xml
        Show
        hudson Hudson added a comment - Integrated in Sqoop-ant-jdk-1.6 #86 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/86/ ) SQOOP-439 : Released artifacts should embrace unwritten naming policy (Revision 1292486) Result = SUCCESS blee : http://svn.apache.org/viewvc/?view=rev&rev=1292486 Files : /incubator/sqoop/trunk/build.xml
        Hide
        bleeapache Bilung Lee added a comment -

        Patch committed. Thanks, Jarcec!

        Show
        bleeapache Bilung Lee added a comment - Patch committed. Thanks, Jarcec!

          People

          • Assignee:
            jarcec Jarek Jarcec Cecho
            Reporter:
            jarcec Jarek Jarcec Cecho
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development