@Jarcec - thanks for filing this. Perhaps the resolution of this issue is to update our How To Release page on the wiki and call out the exact details of how the artifacts should be named. I have the following suggestion:

• Source artifact is named by the project/version as usual: sqoop-1.4.1-incubating.tar.gz
• Binary artifacts are named by project/version with a ".bin" suffix and other details like hadoop version etc. For example: sqoop-1.4.1-incubating.bin__hadoop-0.20.tar.gz

What do you think?

Thank you for your feedback Arvind. I agree with you on suggested naming convention.

I would like to see if ant can be easily modified to generate properly named artifacts instead of changing only the wiki. I would like to have as much as possible done by
ant so that Release Manager do not have to deal with everything manually.

I know that we're going to abandon ant in sqoop 2 and that's why I'm saying "easily modified"

Jarcec

+1 for that Jarcec. Automating this in the build will reduce the burden on RM going forward and worth spending the time to do that.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/
-----------------------------------------------------------

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

Summary
-------

I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

I'll update wiki page "How to Release" in case that this patch will be accepted.

This addresses bug SQOOP-439.
https://issues.apache.org/jira/browse/SQOOP-439

Diffs

/build.xml 1245157

Diff: https://reviews.apache.org/r/3949/diff

Testing
-------

ant srctar
ant tar

• Inside generated artifacts both "ant test" and "ant releaseaudit"

Thanks,

Jarek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5257
-----------------------------------------------------------

Ship it!

Look good overall. Just one minor suggestion below.

/build.xml
<https://reviews.apache.org/r/3949/#comment11474>

value="$

"

• Bilung

On 2012-02-18 16:15:07, Jarek Cecho wrote:

-----------------------------------------------------------

This is an automatically generated e-mail. To reply, visit:

https://reviews.apache.org/r/3949/

-----------------------------------------------------------

(Updated 2012-02-18 16:15:07)

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

Summary

-------

I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

I'll update wiki page "How to Release" in case that this patch will be accepted.

This addresses bug SQOOP-439.

https://issues.apache.org/jira/browse/SQOOP-439

Diffs

-----

/build.xml 1245157

Diff: https://reviews.apache.org/r/3949/diff

Testing

-------

ant srctar

ant tar

- Inside generated artifacts both "ant test" and "ant releaseaudit"

Thanks,

Jarek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/
-----------------------------------------------------------

(Updated 2012-02-22 08:01:10.675913)

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

Changes
-------

Applied Bilung's suggestion.

Summary
-------

I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

I'll update wiki page "How to Release" in case that this patch will be accepted.

This addresses bug SQOOP-439.
https://issues.apache.org/jira/browse/SQOOP-439

Diffs (updated)

/build.xml 1292137

Diff: https://reviews.apache.org/r/3949/diff

Testing
-------

ant srctar
ant tar

• Inside generated artifacts both "ant test" and "ant releaseaudit"

Thanks,

Jarek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5289
-----------------------------------------------------------

Ship it!

+1

• Bilung

On 2012-02-22 08:01:10, Jarek Cecho wrote:

-----------------------------------------------------------

This is an automatically generated e-mail. To reply, visit:

https://reviews.apache.org/r/3949/

-----------------------------------------------------------

(Updated 2012-02-22 08:01:10)

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

Summary

-------

I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

I'll update wiki page "How to Release" in case that this patch will be accepted.

This addresses bug SQOOP-439.

https://issues.apache.org/jira/browse/SQOOP-439

Diffs

-----

/build.xml 1292137

Diff: https://reviews.apache.org/r/3949/diff

Testing

-------

ant srctar

ant tar

- Inside generated artifacts both "ant test" and "ant releaseaudit"

Thanks,

Jarek

On 2012-02-22 19:41:46, Bilung Lee wrote:

> +1

Thank you very much for your review sir. I've already uploaded updated patch to JIRA, so please feel free to commit it in.

• Jarek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3949/#review5289
-----------------------------------------------------------

On 2012-02-22 08:01:10, Jarek Cecho wrote:

-----------------------------------------------------------

This is an automatically generated e-mail. To reply, visit:

https://reviews.apache.org/r/3949/

-----------------------------------------------------------

(Updated 2012-02-22 08:01:10)

Review request for Sqoop, Arvind Prabhakar and Bilung Lee.

Summary

-------

I've changed ant configuration to generate artifacts based on policy that we agreed on JIRA for both source and binary releases.

I've tried to use AntCall (http://ant.apache.org/manual/Tasks/antcall.html) to generate binary artifacts for all supported versions at once, however I wasn't able to get it working in reasonable time.

I'll update wiki page "How to Release" in case that this patch will be accepted.

This addresses bug SQOOP-439.

https://issues.apache.org/jira/browse/SQOOP-439

Diffs

-----

/build.xml 1292137

Diff: https://reviews.apache.org/r/3949/diff

Testing

-------

ant srctar

ant tar

- Inside generated artifacts both "ant test" and "ant releaseaudit"

Thanks,

Jarek

Integrated in Sqoop-ant-jdk-1.6 #86 (See https://builds.apache.org/job/Sqoop-ant-jdk-1.6/86/)
SQOOP-439: Released artifacts should embrace unwritten naming policy (Revision 1292486)

Result = SUCCESS
blee : http://svn.apache.org/viewvc/?view=rev&rev=1292486
Files :

• /incubator/sqoop/trunk/build.xml

Patch committed. Thanks, Jarcec!